Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 15.0 #500

Closed
wants to merge 32 commits into from
Closed

[15.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 15.0 #500

wants to merge 32 commits into from

Conversation

amh-mw
Copy link
Contributor

@amh-mw amh-mw commented Jan 22, 2023

No description provided.

etobella and others added 27 commits January 22, 2023 09:17
@etobella @amh-mw
[ADD] queue_job_batch
9371d56 
[UPD] Update queue_job_batch.pot
@LoisRForgeFlow @amh-mw
[11.0][FIX] queue_job_batch: view all in the systray not working
340326d
@LoisRForgeFlow @amh-mw
[11.0][FIX] queue_job_batch:
dee6577 
* incorrect sintax in security rule
* change missleading name of security rule
@OCA-git-bot @amh-mw
queue_job_batch 11.0.1.1.1
a7edbf7
@OCA-git-bot @amh-mw
[UPD] README.rst
99780b2
@LoisRForgeFlow @amh-mw
[12.0][MIG] queue_job_batch:
eb99aa9 
standard migration and some little ux improvements: now hide
button is a fa-check button that on click just marks as read
the batch, do not navigate to it and updates immediately
the systray.

[UPD] Update queue_job_batch.pot
@OCA-git-bot @amh-mw
[UPD] README.rst
a931acc 
[UPD] Update queue_job_batch.pot
@qgroulard @amh-mw
[12.0] [FIX] Allow users from group queue_job_batch_user to write on …
c311e27 
…batches
@OCA-git-bot @amh-mw
queue_job_batch 12.0.1.0.1
f847861
@OCA-git-bot @amh-mw
[UPD] README.rst
4642a68
@ypapouin @amh-mw
Added translation using Weblate (French)
2c605d6
@ypapouin @amh-mw
Translated using Weblate (French)
c542528 
Currently translated at 100.0% (61 of 61 strings)

Translation: queue-12.0/queue-12.0-queue_job_batch
Translate-URL: https://translation.odoo-community.org/projects/queue-12-0/queue-12-0-queue_job_batch/fr/
@anothingguy @amh-mw
[IMP] queue_job_batch, test_queue_job_batch: black, isort, prettier
3444015
@anothingguy @amh-mw
[14.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 14.0
b096b56
@amh-mw
[UPD] Update queue_job_batch.pot
c887b9b
@OCA-git-bot @amh-mw
[UPD] README.rst
dab4c0c
@etobella @amh-mw
[ADD] test_queue_job_batch
6a01be9 
[UPD] Update test_queue_job_batch.pot
@OCA-git-bot @amh-mw
[UPD] README.rst
88e5824
@OCA-git-bot @amh-mw
[UPD] README.rst
ccd03a5
@LoisRForgeFlow @amh-mw
[12.0][MIG] test_queue_job_batch
345f834 
[UPD] Update test_queue_job_batch.pot
@OCA-git-bot @amh-mw
[UPD] README.rst
bae6391
@ypapouin @amh-mw
Added translation using Weblate (French)
cfbb757
@anothingguy @amh-mw
[IMP] queue_job_batch, test_queue_job_batch: black, isort, prettier
737cae5
@anothingguy @amh-mw
[14.0][MIG] queue_job_batch, test_queue_job_batch: Migration to 14.0
e8af807
@amh-mw
[UPD] Update test_queue_job_batch.pot
24c8f26
@OCA-git-bot @amh-mw
[UPD] README.rst
d49e645
@amh-mw
[IMP] queue_job_batch, test_queue_job_batch: black, isort, prettier
be22b7b
@amh-mw amh-mw mentioned this pull request Jan 22, 2023
Closed
9 tasks
@amh-mw
Copy link
Contributor Author

amh-mw commented Jan 22, 2023

@agenterp Since you noticed the lack of this module in the 15.0 milestone, mind giving it a review?

@jans23 jans23 mentioned this pull request Feb 22, 2023
Merged
@amh-mw
Copy link
Contributor Author

amh-mw commented Apr 3, 2023

@jans23 Would you mind reviewing this pull request?

@jans23
Copy link

jans23 commented Apr 3, 2023

Ok, will put it on our team's task list.

@alihashaam
Copy link

@amh-mw

There is a small issue with the way qweb is referenced in manifest file of queue_job_batch module of this PR.

as if you look in the base modules, it should be done as follow. This solved the error [1] for me as otherwise I was getting the error [1] that :

[1] Qweb template "queue_job_batch.view.Menu" not found

"assets": { "web.assets_qweb": [ "queue_job_batch/static/src/xml/systray.xml", ],

I would like to push this change but I dont have access to repo. How would you prefer I proceed?

@alihashaam
Copy link

@amh-mw

Please find our work in PR:
amh-mw#1

@jans23 the module was also reviewed and two other small changes were included in above PR.

@amh-mw
Merge pull request #1 from Nitrokey/15.0-mig-queue_job_batch
5072551 
[15.0][IMP] qweb reference changed in manifest file
@amh-mw
Copy link
Contributor Author

amh-mw commented Jun 1, 2023

@alihashaam Thanks for the help!

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 1, 2023
@github-actions github-actions bot closed this Nov 5, 2023
@amh-mw amh-mw deleted the 15.0-mig-queue_job_batch branch December 20, 2023 16:45
@amh-mw
Copy link
Contributor Author

amh-mw commented Mar 7, 2024

Reopened as #633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@amh-mw @jans23 @alihashaam @etobella @LoisRForgeFlow @OCA-git-bot @qgroulard @ypapouin @anothingguy