[14.0][IMP] export_async_schedule : Send attachments directly #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quoc-pn
force-pushed
the
14.0-imp-export_async_schedule
branch
from
bc39016
to
d946094
Compare
|
Hi @guewen, |
cuongnmtm
suggested changes
Nov 15, 2023
There was a problem hiding this comment.
Please help to add to the description what are the improvements.
- Add ability to specify mail template for export.async.schedule.
- Add ability to attach the export attachment to the email.
These two new features will help in case you want to send the export file to someone who doesn't have access to do (so they cannot open the link).
cuongnmtm
reviewed
Nov 15, 2023
quoc-pn
force-pushed
the
14.0-imp-export_async_schedule
branch
from
d946094
to
9699909
Compare
quoc-pn
force-pushed
the
14.0-imp-export_async_schedule
branch
from
9699909
to
2725ce2
Compare
quoc-pn
force-pushed
the
14.0-imp-export_async_schedule
branch
from
2725ce2
to
910538b
Compare
quoc-pn
force-pushed
the
14.0-imp-export_async_schedule
branch
from
910538b
to
78afa1c
Compare
quoc-pn
force-pushed
the
14.0-imp-export_async_schedule
branch
from
78afa1c
to
ee429fb
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement:
Add the ability to specify mail template for export.async.schedule.
Add the ability to attach the export attachment to the email.
These two new features will help if you want to send the export file to someone who doesn't have access to do (so they cannot open the link).