Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [ADD] queue_job_web_notify: send web notifications from queue jobs #628

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

ThomasBinsfeld
Copy link
Contributor

@ThomasBinsfeld ThomasBinsfeld commented Mar 4, 2024

This module extends the mail notification feature of Queue Job.

It adds the possibility to enable the web notification of failed jobs.

When enabled, the user will be notified by a web notification. The web notification is a pop-up message that appears in the user's browser.


Migration of #627

This module extends the mail notification feature of Queue Job.
It adds the possibility to enable the web notification of failed jobs.
When enabled, the user will be notified by a web notification.
The web notification is a pop-up message that appears in the user's browser.
Copy link
Member

@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: code review

Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@guewen
Copy link
Member

guewen commented Apr 4, 2024

/ocabot merge nobump

OCA-git-bot added a commit that referenced this pull request Apr 4, 2024
Signed-off-by guewen
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-628-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-628-by-guewen-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7196bf8 into OCA:16.0 Apr 4, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fd49d74. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants