-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] queue_job: HA job runner using session level advisory lock #668
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @guewen, |
1f9155c
to
54620ab
Compare
Without this, we leak connections to Databases that don't have queue_job installed.
Without this we risk connection leaks in case of exceptions in the constructor.
54620ab
to
02ef89b
Compare
02ef89b
to
deecd27
Compare
Yep, this should work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
@PCatinean do you know who we should ping in the odoo.sh team to have an opinion on this approach? |
@amigrave @sts-odoo so the TL;DR here is that we have one long lived connection to the database on which we take a session-level advisory lock and do a I plan to deploy this on a odoo.sh dev env soon to see how it goes. I can PM you the details if you wish to monitor something. |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Another attempt.