Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] rma_lot: Migration to 17.0 #431

Merged
merged 5 commits into from
Oct 23, 2024
Merged

[17.0][MIG] rma_lot: Migration to 17.0 #431

merged 5 commits into from
Oct 23, 2024

Conversation

peluko00
Copy link

@peluko00 peluko00 commented Oct 18, 2024 •
edited
Loading

@peluko00 peluko00 mentioned this pull request Oct 18, 2024
Open
5 tasks
@rousseldenis
Copy link
Contributor

@peluko00 Thanks for this.

FYI, you can embed depending PR's following: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

This allows to:

  • Run tests
  • Run runboat and allows functional review

@rousseldenis
Copy link
Contributor

/ocabot migration rma_lot

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Oct 18, 2024
@rousseldenis
Copy link
Contributor

To improve review process, don't hesitate to add link to depending PR in this description

@peluko00
Copy link
Author

peluko00 commented Oct 18, 2024 •
edited
Loading

@peluko00 Thanks for this.

FYI, you can embed depending PR's following: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

This allows to:

  • Run tests
  • Run runboat and allows functional review

Of course, i'll do it!

mpascuall
mpascuall approved these changes Oct 18, 2024
View reviewed changes
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in runboat

@peluko00 peluko00 mentioned this pull request Oct 21, 2024
Open
@peluko00
Copy link
Author

It's ready to be merge @rousseldenis?

BernatObrador
BernatObrador approved these changes Oct 23, 2024
View reviewed changes
Copy link

@BernatObrador BernatObrador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, tested in runboat and code review

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-431-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d462d2c into OCA:17.0 Oct 23, 2024
9 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dc28c13. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpascuall mpascuall mpascuall approved these changes

@BernatObrador BernatObrador BernatObrador approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@peluko00 @rousseldenis @OCA-git-bot @BernatObrador @mpascuall @sbejaoui