[17.0][MIG] auth_jwt: Migration to 17.0 #751
Conversation
kobros-tech
force-pushed
the
17.0-mig-auth_jwt
branch
2 times, most recently
from
eb0dbc2 to
0f36b23
Compare
Because it allows validating with a list of audiences.
Make it work with pyjwt.
This method is useful for public endpoints that need to work for anonymous user, but can be enhanced when an authenticated user is know. A typical use case is a "add to cart" enpoint that can work for anonymous users, but can be enhanced by binding the cart to a known customer when the authenticated user is known.
The unit tests were broken for non-functional reasons (interaction with the mock) and is easier to implement as integration test.
Distinguish errors that lead to a 401 from internal configuration errors.
Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/es/
Currently translated at 89.0% (57 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
kobros-tech
force-pushed
the
17.0-mig-auth_jwt
branch
from
794ee01 to
04b259a
Compare
|
I am learining how to respect log using rebase command :) |
|
@kobros-tech The migration should be redone to avoid to add the pandoc-3.2.1-amd64.deb file into the git history. It has been added in 99863ac It's no more part of the commit history on the 16.0 branch. |
I don't understand, in the MIG PR stephan asked to remove .deb file and I removed it here. I didn't catch up what you meant. |
kobros-tech
force-pushed
the
17.0-mig-auth_jwt
branch
from
04b259a to
559b3fe
Compare
|
I understand now, the only commit is [MIG] I removed all commits since the one you mentioned, so pandoc.deb will not be there in the git log. we will improve also the [MIG][18.0] commit with MR. Don @dnplkndll |
kobros-tech
changed the title
There was a problem hiding this comment.
Thank you for your work @kobros-tech The code LGTM now. Some commits could miss but I'll take care to sync the 16.0 and 17.0 branches in the next weeks so let's move forward.
|
I compared with v16. This looks good. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Thanks for the migration @kobros-tech ! |
|
Congratulations, your PR was merged at 0a15bad. Thanks a lot for contributing to OCA. ❤️ |
cleaning up for migration
#657