Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] Migration of module_auto_update #3186

Merged
merged 24 commits into from
Feb 20, 2025
Merged

[18.0][MIG] Migration of module_auto_update #3186

merged 24 commits into from
Feb 20, 2025

Conversation

fkantelberg
Copy link
Member

  • No real change was needed just a small swap from %-formatting to .format as requested by CI/ruff [UP031]

@fkantelberg fkantelberg mentioned this pull request Feb 5, 2025
Open
29 tasks
StefanRijnhart
StefanRijnhart requested changes Feb 7, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you mention in the documentation that click-odoo-update exists as an alternative (https://github.com/acsone/click-odoo-contrib) which implements the same functionality but is run as an external python tool so it is easier to integrate with other non-Odoo maintenance tools.

@StefanRijnhart
Copy link
Member

Tests are fixed in #3190. Your review there would be welcome.

@fkantelberg fkantelberg force-pushed the 18.0-mig-module_auto_update branch from 6d3c2c9 to 156dca5 Compare February 7, 2025 12:22
@fkantelberg
Copy link
Member Author

Thank you for the review. I indeed missed the changes in the hook and it's nice to know.

I added a reference to click-odoo-update. It's a nice alternative from the community but no replacement because it brings the dependencies differently from my point of view.

OCA-git-bot and others added 24 commits February 7, 2025 13:33
@OCA-git-bot @fkantelberg
README.rst
a8b423d
@ibuioli @fkantelberg
Added translation using Weblate (Spanish (Argentina))
887c05f
@ibuioli @fkantelberg
Translated using Weblate (Spanish (Argentina))
1b6bc56 
Currently translated at 100.0% (4 of 4 strings)

Translation: server-tools-15.0/server-tools-15.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_auto_update/es_AR/
@StefanRijnhart @fkantelberg
dotfiles
39de814
@OCA-git-bot @fkantelberg
module_auto_update 15.0.1.0.1
214e451
@fkantelberg
module_auto_update: Migration to 16.0
4389a24
@fkantelberg
Update module_auto_update.pot
765f8f0
@OCA-git-bot @fkantelberg
README.rst
048409c
@weblate @fkantelberg
Update translation files
d1be4bd 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/
@fkantelberg
Update module_auto_update.pot
5e9a483
@weblate @fkantelberg
Update translation files
111822e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/
@ibuioli @fkantelberg
Translated using Weblate (Spanish (Argentina))
be7053a 
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-16.0/server-tools-16.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/es_AR/
@Ivorra78 @fkantelberg
Translated using Weblate (Spanish)
56cf53a 
Currently translated at 100.0% (5 of 5 strings)

Translation: server-tools-16.0/server-tools-16.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/es/
@OCA-git-bot @fkantelberg
README.rst
310e31b
@mymage @fkantelberg
Translated using Weblate (Italian)
a33617c 
Currently translated at 60.0% (3 of 5 strings)

Translation: server-tools-16.0/server-tools-16.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-module_auto_update/it/
@fkantelberg
module_auto_update: pre-commit auto fixes
f571a7a
@fkantelberg
module_auto_update: Migration to 17.0
449dc96
@thomaspaulb @fkantelberg
enable test that got disabled
ac03705
@fkantelberg
Update module_auto_update.pot
a266a7c
@OCA-git-bot @fkantelberg
post-merge updates
32c7cfa
@weblate @fkantelberg
Update translation files
c53d1f3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-module_auto_update/
@mymage @fkantelberg
Translated using Weblate (Italian)
0343748 
Currently translated at 100.0% (4 of 4 strings)

Translation: server-tools-17.0/server-tools-17.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-module_auto_update/it/
@xtanuiha @fkantelberg
Translated using Weblate (Chinese (Simplified) (zh_CN))
549078c 
Currently translated at 100.0% (4 of 4 strings)

Translation: server-tools-17.0/server-tools-17.0-module_auto_update
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-module_auto_update/zh_CN/
@fkantelberg
[18.0][MIG] module_auto_update: Migration to 18.0
3c05f96
@fkantelberg fkantelberg force-pushed the 18.0-mig-module_auto_update branch from 156dca5 to 3c05f96 Compare February 7, 2025 12:33
StefanRijnhart
StefanRijnhart approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, if you rely on the server action from this module it's not a replacement. Thanks for the changes.

@Garcicasti
Copy link

Hey @StefanRijnhart is it possible to merge this one? Thanks!

@StefanRijnhart
Copy link
Member

@Garcicasti asking for a merge is not helpful, but doing a review is!

jmartinacu
jmartinacu approved these changes Feb 20, 2025
View reviewed changes
Copy link

@jmartinacu jmartinacu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se ha revisado y probado la Pull Request y cumple con los siguientes criterios:

  • Funcionamiento validado: Todas las funcionalidades implementadas o modificadas han sido verificadas y funcionan correctamente en el entorno de prueba.
  • Tests exitosos: Se han ejecutado todas las pruebas automatizadas y han pasado sin errores. Además, se ha confirmado que los checks necesarios siguen ejecutándose correctamente.
  • Documentación y comentarios: El código está bien documentado y, en caso necesario, se han actualizado los archivos de documentación relevantes.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Garcicasti
Copy link

@StefanRijnhart Alright, my colleague @jmartinacu just reviewed and approve it. Can it be merged now that it has 2 reviews? Thanks!

And BTW, communicating in a non passive-aggresive way is also helpful!

@StefanRijnhart
Copy link
Member

@Garcicasti you are right, I should not have taken it out on you. Thanks for the review!

/ocabot migration module_auto_update
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 20, 2025
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-3186-by-StefanRijnhart-bump-nobump, awaiting test results.

@StefanRijnhart
Copy link
Member

@fkantelberg We need to check next time if an existing migration PR already exists. I'm now seeing #3119.

@OCA-git-bot OCA-git-bot merged commit 9dcb20d into OCA:18.0 Feb 20, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e697148. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart StefanRijnhart mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@jmartinacu jmartinacu jmartinacu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.