[16.0] [ADD] multisearch_field #967

TB-Ph35 · 2024-11-07T07:46:30Z

This module add multi-searching with separator for all search.

It add to model.search() code to enable searching with separator.
example:

you are searching "Tom|kelly;hart"
If the separator are "|" and ";"
it will search for "Tom|kelly;hart", "Tom|kelly", "Tom", "kelly;hart", "kelly" and "hart"

legalsylvain

Nice work ! thanks for sharing.

some minor remarks inline. Otherwise, LGTM.

legalsylvain · 2024-11-07T07:50:45Z

base_multi_search_separator/readme/USAGE.rst

@@ -0,0 +1,6 @@
+To configure the separator you must:


better to put this part in a CONFIGURE.rst section.

In the USAGE file you can put a print screen. (something like "before" / "after").

legalsylvain · 2024-11-07T07:51:34Z

base_multi_search_separator/readme/DESCRIPTION.rst

@@ -0,0 +1 @@
+* This module allows mulit_searching for all search.


could you elaborate the description ? say exactly what the modules does.
(there are some base_search_xxx module in the OCA, like base_name_search_improved, base_search_fuzzy, etc...)

legalsylvain · 2024-11-07T07:56:38Z

base_multi_search_separator/monkeypatching.py

+        else:
+            domain_list.append(dom)
+    for _ in range(nbr):
+        domain_list.append("|")


I think you can manipulate all the domain with expression.OR and expression.AND. It will be more readable I think.

legalsylvain · 2024-11-07T07:57:51Z

base_multi_search_separator/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    "name": "MultiSearch",


too generic title in my opinion.

bealdav · 2024-11-07T12:15:31Z

Thanks @TB-Ph35 for this contribution.

Regarding the module name, it's not an easy topic, isn't it?
If we want to make the name meaningful, we need to add meaningful terms and remove some.
I guess base_ doesn't help to understand what the module does.

What the module does, if I understood correctly, is to allow searching for multiple values of a particular field.

separator is the way to do it, not what it does

To make this understandable with the module name, some candidates could be:

field_multisearch
multisearch_field

another suggestion?

legalsylvain · 2024-11-07T12:34:34Z

FYI, my remarks regarding the name was about the value "name" in the manifest, not the technical name.

TB-Ph35 · 2024-11-07T13:53:05Z

Thanks for all the comment.

With those comment, i have made changes. But not the names module. It is not easy like you said, and that's really not my game. I will think about it.

legalsylvain · 2024-11-07T14:25:35Z

base_multi_search_separator/__manifest__.py

@@ -0,0 +1,15 @@
+{
+    "name": "Field MultiSearch with separotor",


Suggested change

"name": "Field MultiSearch with separotor",

"name": "Field MultiSearch with separator",

typo.

PaulGoubert · 2024-11-07T14:32:35Z

LGTM. Thank you for your work, Thomas.

I tried on the Customer Invoice by doing a search with:

Just one remark: once we want to copy and paste several lines from an XLS sheet, we don't have a separator, but only a space.
So in that case, we have to add the separator and remove the space before copying to make the search work.

It could be very interesting to have the space consideration in the search, or even as a separator itself.

PaulGoubert · 2024-11-07T15:35:25Z

Concerning the name, for my point of view, the main thing is to have multisearch in the module name. Then as @bealdav mentionned, field_multisearch or multisearch_field look good for me.

If the Space is concidered as a "separator", the name separator is not required in the module name.

TB-Ph35 · 2024-11-07T15:52:38Z

I will look for adding the space. But now it can be add to the list of separator because for some search it broke the search. Like for self.env["resource.calendat.leaves"]. It split datetimeformat and that make this error :

psycopg2.errors.InvalidDatetimeFormat: invalid input syntax for type timestamp: "16:23:06"
LINE 1: ...')) OR ("resource_calendar_leaves"."date_from" <= '16:23:06'...

if i don't understand it wrong

PaulGoubert · 2024-11-12T08:53:27Z

The search with space work fine now with / before the search.
For product for ex : /E-COM06 E-COM07 E-COM08

Thank you @TB-Ph35

PaulGoubert

Functionnal review OK

multisearch_field/__manifest__.py

bealdav

Great job Thomas, really useful module, some typo comments here.
Could you crop your images to focus on parts without white page color to see that you want to show.
Probably squash commits could be nice
Thanks a lot.

bealdav · 2024-11-13T07:45:25Z

multisearch_field/readme/DESCRIPTION.rst

+This module allows mulit_searching for all search.
+For that, it add code before the search function.
+
+It will allows you to search for multi_value separate by the character that you


Suggested change

It will allows you to search for multi_value separate by the character that you

It will allow you to search for multiple values separated by the character you

bealdav · 2024-11-13T07:45:55Z

multisearch_field/readme/DESCRIPTION.rst

+For that, it add code before the search function.
+
+It will allows you to search for multi_value separate by the character that you
+have configure.


Suggested change

have configure.

have configured.

bealdav · 2024-11-13T07:46:30Z

multisearch_field/data/multi_search_data.xml

@@ -0,0 +1,6 @@
+<odoo noupdate="1">
+    <record id="multi_search_separator" model="ir.config_parameter">
+        <field name="key">multi_search_separator_base</field>


Suggested change

<field name="key">multi_search_separator_base</field>

<field name="key">multi_search_separator</field>

bealdav · 2024-11-13T07:46:58Z

multisearch_field/monkeypatching.py

+    fields"""
+    if self.env["ir.model.access"].check_access_rights("read", raise_exception=False):
+        list_separator = self.env["ir.config_parameter"].get_param(
+            "multi_search_separator_base"


Suggested change

"multi_search_separator_base"

"multi_search_separator"

bealdav · 2024-11-13T07:47:14Z

multisearch_field/readme/CONFIGURE.rst

+To configure the separator you must:
+    * be in dev_mode
+    * go to Settings / technical / system parameter
+    * search multi_search_separator_base


Suggested change

* search multi_search_separator_base

* search multi_search_separator

multisearch_field/tests/test_multi_search.py

+
+class TestMultisearch(TransactionCase):
+    def setUp(self):
+        super(TestMultisearch, self).setUp()


bealdav

Nice, thanks a lot

OCA-git-bot · 2024-11-14T17:19:16Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

legalsylvain reviewed Nov 7, 2024

View reviewed changes

PaulGoubert approved these changes Nov 12, 2024

View reviewed changes

bealdav reviewed Nov 12, 2024

View reviewed changes

multisearch_field/__manifest__.py Outdated Show resolved Hide resolved

TB-Ph35 force-pushed the 16.0-base_multi_search_separator branch from 6a6f4c0 to 1fac86e Compare November 12, 2024 21:11

bealdav reviewed Nov 13, 2024

View reviewed changes

[ADD] Module multisearch_field

42d551e

TB-Ph35 force-pushed the 16.0-base_multi_search_separator branch from 1fac86e to 42d551e Compare November 14, 2024 13:57

TB-Ph35 changed the title ~~16.0 base multi search separator~~ [16.0] [ADD] multisearch_field Nov 14, 2024

bealdav approved these changes Nov 14, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0] [ADD] multisearch_field #967

[16.0] [ADD] multisearch_field #967

TB-Ph35 commented Nov 7, 2024

legalsylvain left a comment

legalsylvain Nov 7, 2024

legalsylvain Nov 7, 2024

legalsylvain Nov 7, 2024

legalsylvain Nov 7, 2024

bealdav commented Nov 7, 2024

legalsylvain commented Nov 7, 2024

TB-Ph35 commented Nov 7, 2024

legalsylvain Nov 7, 2024

PaulGoubert commented Nov 7, 2024

PaulGoubert commented Nov 7, 2024

TB-Ph35 commented Nov 7, 2024

PaulGoubert commented Nov 12, 2024

PaulGoubert left a comment

bealdav left a comment

bealdav Nov 13, 2024

bealdav Nov 13, 2024

bealdav Nov 13, 2024

bealdav Nov 13, 2024

bealdav Nov 13, 2024

This comment was marked as outdated.

bealdav left a comment

OCA-git-bot commented Nov 14, 2024

		@@ -0,0 +1 @@
		* This module allows mulit_searching for all search.

		@@ -0,0 +1,15 @@
		{
		"name": "Field MultiSearch with separotor",

	"name": "Field MultiSearch with separotor",
	"name": "Field MultiSearch with separator",

	It will allows you to search for multi_value separate by the character that you
	It will allow you to search for multiple values separated by the character you

	<field name="key">multi_search_separator_base</field>
	<field name="key">multi_search_separator</field>

	* search multi_search_separator_base
	* search multi_search_separator

[16.0] [ADD] multisearch_field #967

Are you sure you want to change the base?

[16.0] [ADD] multisearch_field #967

Conversation

TB-Ph35 commented Nov 7, 2024

legalsylvain left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bealdav commented Nov 7, 2024

legalsylvain commented Nov 7, 2024

TB-Ph35 commented Nov 7, 2024

Choose a reason for hiding this comment

PaulGoubert commented Nov 7, 2024

PaulGoubert commented Nov 7, 2024

TB-Ph35 commented Nov 7, 2024

PaulGoubert commented Nov 12, 2024

PaulGoubert left a comment

Choose a reason for hiding this comment

bealdav left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

bealdav left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Nov 14, 2024