[16.0][ADD] stock_picking_status_notification: Add new module to notify user after change picking states

[GabbasovDinar]

This module allows to send notifications to selected backend users when the state of stock picking changes . For this configurable notification rules are used. Rules are checked using flexible patterns. The first one rule matching the pattern is triggered.

Task: 3874

[rvalyi]

Just an observation: some modules similar modules with mail templates like edi_notification or account_bank_payment_notification use the notification suffix instead of notify. In the OCA the notify suffix has been used in web_notify for server push. So I wonder if it might not be better to user notification here for consistency. I don't have a strong opinion about this; it's just an observation.

cc @pedrobaeza @sbidoul

[pedrobaeza]

About the formal aspect, the tag of the commit should be [ADD], not [NEW]. About the module name and feature, stock_picking_state_tracking can be more appropriated if the implementation is with a mail subtype and directly subscribers of the thread receive the notifications using standard options. You can put that subtype inheritable in picking types.

[ivs-cetmix]

About the formal aspect, the tag of the commit should be [ADD], not [NEW]. About the module name and feature, stock_picking_state_tracking can be more appropriated if the implementation is with a mail subtype and directly subscribers of the thread receive the notifications using standard options. You can put that subtype inheritable in picking types.

Hello @pedrobaeza thank you for your feedback!
Actually this module has nothing to do with the standard tracking mechanism. Moreover people who will get notified can be even not the followers of the document they are notified about.
I have put the general idea into the CONTEXT section, here is some further elaboration:
We have a warehouse with around 30 people working there. Odoo is installed on the laptop which is located on a table in the middle. So once a new SO is completed in the shop someone should take care of it.
Actually we are going to use sound notification because people are not just sitting at the table and waiting.
Here is a PR for that: OCA/web#2923

[pedrobaeza]

Well, I think that should be a pro-active action, checking a list of "completed orders" more than a reactive one, having a notification per order (even with sound), but anyone takes the approach they consider...

stock_picking_status_notification then for the current approach of the module.

[ivs-cetmix]

Well, I think that should be a pro-active action, checking a list of "completed orders" more than a reactive one, having a notification per order (even with sound), but anyone takes the approach they consider...

stock_picking_status_notification then for the current approach of the module.

This is not the case here. This will require someone stop his work, go to the laptop and check the orders any eg 10 minutes.
Which will lead to the excessive time loss. Because sometimes there can be one order in 2-3 minutes, and sometimes there can be no orders for an hour.

[pedrobaeza]

I see something weird in that flows, but I'm not blocking anyway. I don't see normal that someone has to stop their work to do "something" on that case. Automate that "something" or batch it somehow.

[ivs-cetmix]

I see something weird in that flows, but I'm not blocking anyway. I don't see normal that someone has to stop their work to do "something" on that case. Automate that "something" or batch it somehow.

Well this happens. Let's say you are packing the website orders which are queued and planned. But when there is an offline sale and the customer is here you to serve him right now. And then continue with your website orders.

[pedrobaeza]

Uhm, OK, that seems a real need, although missing the notification/sound seems a real possibility, so you should consider a fallback.

[ivs-cetmix]

Functional review LGTM

[hoangtrann]

Code LGTM