Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD] stock_quant_serial_partner_location #1735

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

Christian-RB
Copy link

No description provided.

stock_quant_serial_partner_location/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
@@ -0,0 +1,4 @@
This module remove the check on serial number quants when the location is type customer or vendor.
It is usefull to specific situation, when you sell products to one company and then the same one provide

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the use case for this module? I tested and it works as intended, but it seems to me a bit dangerous that when installing this module, you can send out the same serial number twice.

Why would this be needed? Because a serial number normally can reside only in one place.

Maybe you can give a specific example of a dropship flow in which this happens, in steps.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thomaspaulb, thanks for the review. Here are the steps to reproduce the issue:

  1. Setup:

    • Company A and Company B are separate entities.
    • Company A initially stores products in its own warehouse and regularly sells them.
  2. Scenario:

    • Company A decides to stop storing products in its own warehouse and instead subcontracts Company B to handle dropshipping for them.
    • As part of this change, Company A sells all of its stock to Company B (using the purchase_sale_inter_company module in Odoo to facilitate this process).
    • Company A delivers the products to Company B with serialized numbers, which Company B retains.
  3. Issue:

    • When Company A sells a product via dropshipping, Company B fulfills the delivery to the end customer.
    • An error is triggered because Company A is trying to register a delivery to the customer using the same serial numbers already used in the transfer to Company B.

This is indeed a specific situation, but it could potentially affect others in a similar setup. If it’s a one-time scenario, performing an inventory adjustment on the customer location might temporarily resolve it, but I’m uncertain about the long-term correctness of that approach.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for explaining the scenario!

I wonder why you get an error in that scenario, because we have exactly the same setup as you describe for a customer, but we don't get that error. It's probably because in our case, we maintain the multi-company security rule on serial numbers, so we dont share serial numbers between companies - they have to be copied. (OCA intercompany module copies them automatically, not sure about Odoo Enterprise version).

Because they are copied you wont get the error because the serial numbers are different records with different ids

@Christian-RB Christian-RB force-pushed the 14.0-add-stock_quant_serial_partner_location branch from 7fc1543 to 877470b Compare November 11, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants