Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] Web advanced search select dialog #2033

Open
wants to merge 8 commits into
base: 14.0
Choose a base branch
from

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented Sep 21, 2021

Restore the in old versions existing 'is in selection' operator.

Note that this build on the improvements in #2003

@NL66278 NL66278 force-pushed the 14.0-web_advanced_search-select-dialog branch 4 times, most recently from 713641f to 61096c5 Compare September 22, 2021 15:24
@NL66278 NL66278 changed the title [14.0][WIP] web advanced search select dialog [14.0] Web advanced search select dialog Sep 22, 2021
@NL66278
Copy link
Contributor Author

NL66278 commented Sep 22, 2021

@hbrunn I tried to recreate on Odoo 14.0 what you created a long time ago, and that some customers were sorely missing. Would be nice if you had a look, It is my first non-trivial web development.

@NL66278
Copy link
Contributor Author

NL66278 commented Oct 29, 2021

@jgrandguillaume Very interesting talk you gave!

You mentioned the web_advanced_search module, that could be made even more fantastic with the features offered here, that recreates some of the original functionality created by @hbrunn, that was lost in later migrations.

@rven
Copy link
Contributor

rven commented Nov 17, 2021

The button Use criteria does not get enabled when a domain is entered
image

@NL66278
Copy link
Contributor Author

NL66278 commented Dec 2, 2021

@rven Strange, this was working before. I will try to find out what went wrong.

@NL66278
Copy link
Contributor Author

NL66278 commented Dec 2, 2021

One of those horrible problems that do not exist when debugging... Must be some timing issue...

@rven
Copy link
Contributor

rven commented Dec 2, 2021

@NL66278
The following error rises on runbot, when selecting the in selection option of the Custom Filter
image

tested on http://3519656-2033-61096c.runbot2.odoo-community.org/web#action=35&model=ir.module.module&view_type=kanban&cids=1&menu_id=5

@xavier-bouquiaux
Copy link

LGTM

I've just installed you PR on my project and it works as designed

@spadae22
Copy link

@NL66278 Hi, You updated this for me at therp, use criteria is not working, I have emailed your directly with no response, please help.

Copy link

@spadae22 spadae22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NL66278 Thanks! I am emailing you now and Therp on the conflict with othe module you made for me. It can be added to OCA to, it is much nicer than Odoo Category.

@NL66278 NL66278 force-pushed the 14.0-web_advanced_search-select-dialog branch 3 times, most recently from 6abee29 to 576361d Compare August 10, 2023 16:16
@NL66278 NL66278 force-pushed the 14.0-web_advanced_search-select-dialog branch from 576361d to a953121 Compare September 4, 2023 12:00
@NL66278
Copy link
Contributor Author

NL66278 commented Mar 21, 2024

@rven Could you have another look?

@bosd
Copy link
Contributor

bosd commented Mar 21, 2024

Hmm.. Maybe I'm missing something here. How does one apply the 'is in selection' operator.
Is it broken by the latest commit? Or maybe I don't understand the readme / workflow 🤔

Can you make short screencast?

@gfcapalbo
Copy link

gfcapalbo commented Mar 25, 2024

Hmm.. Maybe I'm missing something here. How does one apply the 'is in selection' operator. Is it broken by the latest commit? Or maybe I don't understand the readme / workflow 🤔

Can you make short screencast?

here is a screencast of selecting "in selection" option:

for_euge.mp4

@NL66278
Copy link
Contributor Author

NL66278 commented Mar 25, 2024

Hmm.. Maybe I'm missing something here. How does one apply the 'is in selection' operator. Is it broken by the latest commit? Or maybe I don't understand the readme / workflow 🤔
Can you make short screencast?

here is a screencast of selecting "in selection" option:
for_euge.mp4

@spadae22 @gfcapalbo On my linux does not open in Firefox, but does run in Chromium.

@bosd
Copy link
Contributor

bosd commented Mar 26, 2024

@gfcapalbo Thanks for the screencast.

I was able to add a filter on the runboat.

But I also got an error..
On runbot I follow this:
Go to Apps

Add Cutsom Filter --> Author --> is in selection


Error:
Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/opt/odoo/odoo/http.py", line 696, in dispatch
    result = self._call_function(**self.params)
  File "/opt/odoo/odoo/http.py", line 328, in _call_function
    raise werkzeug.exceptions.BadRequest(msg % params)
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 652, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/odoo/http.py", line 317, in _handle_exception
    raise exception.with_traceback(None) from new_cause
werkzeug.exceptions.BadRequest: 400 Bad Request: <function Home.web_client at 0x7f8ac9faa430>, /web: Function declared as capable of handling request of type 'http' but called with a request of type 'json'

@NL66278
Copy link
Contributor Author

NL66278 commented Mar 26, 2024

@gfcapalbo The error occurs when selecting on a non relational field (like Author or Description). These have no tree views or list, so an 'in selection' filter makes no sense. So the 'in selection' operator should only be shown for relational fields. Would that be easy to add?

@gfcapalbo
Copy link

@gfcapalbo The error occurs when selecting on a non relational field (like Author or Description). These have no tree views or list, so an 'in selection' filter makes no sense. So the 'in selection' operator should only be shown for relational fields. Would that be easy to add?

@NL66278 Please assign an internal issue with necessary priority, it should be possible , but not immediate, to filter out all non-relational fields from the options available when using "is in selection".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants