Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] web_widget_remote_measure: New module #2407

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

chienandalu
Copy link
Member

cc @Tecnativa TT38745

ping @carlosdauden

Example of behavior in the oncoming stock_remote_device:

remote-device-example

@pedrobaeza
Copy link
Member

Being web client implementation, I think it should be called web_widget_remote_measure or similar.

@pedrobaeza pedrobaeza added this to the 15.0 milestone Feb 9, 2023
@chienandalu chienandalu changed the title [15.0][ADD] base_remote_measure: New module [15.0][ADD] web_widget_remote_measure: New module Feb 9, 2023
@chienandalu
Copy link
Member Author

Ok, changed :)

@pedrobaeza
Copy link
Member

I wonder the overlap with https://odoo-community.org/shop/remote-base-3251?search=remote#attr=21539 and indeed seeing this code, it's including in the same module the base definition with the widget.

@pedrobaeza
Copy link
Member

This is also a very specific "remote" thing, so maybe including websocket reference or something can be convenient.

@chienandalu
Copy link
Member Author

I wonder the overlap with https://odoo-community.org/shop/remote-base-3251?search=remote#attr=21539 and indeed seeing this code, it's including in the same module the base definition with the widget.

I'd say that module's purpose is to store the accesses to the Odoo server

@chienandalu
Copy link
Member Author

This is also a very specific "remote" thing, so maybe including websocket reference or something can be convenient.

It can be extended to a Webservices interface in the future if needed

@pedrobaeza
Copy link
Member

Then remote_webservice prefix?

@chienandalu
Copy link
Member Author

But it could be either webservices or websockets

@pedrobaeza
Copy link
Member

OK, I don't insist then.

@rousseldenis
Copy link
Contributor

And why not envisaging connecting devices like IOT (that could be connected to POS) and more specifically to pywebdriver ?

That allows you to implement protocols there. With the advantage of being available for all flows you want.

@chienandalu
Copy link
Member Author

And why not envisaging connecting devices like IOT (that could be connected to POS) and more specifically to pywebdriver ?
That allows you to implement protocols there. With the advantage of being available for all flows you want.

Connection to any remote measure device (IoT or the device itself via web services) would be possible if implemented but we want to keep the infrastructure required to implement this in the customer's setup as simple as possible.

For our current approach, adding an IoT (or pywebdriver) in the middle is an extra point of potential failure that can complicate our maintenance.

@rousseldenis
Copy link
Contributor

And why not envisaging connecting devices like IOT (that could be connected to POS) and more specifically to pywebdriver ?
That allows you to implement protocols there. With the advantage of being available for all flows you want.

Connection to any remote measure device (IoT or the device itself via web services) would be possible if implemented but we want to keep the infrastructure required to implement this in the customer's setup as simple as possible.

For our current approach, adding an IoT (or pywebdriver) in the middle is an extra point of potential failure that can complicate our maintenance.

So, implementing a particular protocol should maybe go in another module

@chienandalu chienandalu force-pushed the 15.0-add-base_remote_measure branch 3 times, most recently from 23f1267 to 44cb7bd Compare February 13, 2023 11:05
@chienandalu chienandalu force-pushed the 15.0-add-base_remote_measure branch from 44cb7bd to a527c20 Compare May 16, 2023 15:30
@chienandalu chienandalu force-pushed the 15.0-add-base_remote_measure branch 6 times, most recently from 95f0027 to 0478ffd Compare May 25, 2023 14:37
@chienandalu chienandalu force-pushed the 15.0-add-base_remote_measure branch 8 times, most recently from 7ef5746 to c9a7f61 Compare June 1, 2023 07:28
@bosd
Copy link
Contributor

bosd commented Jul 31, 2023

Let us know when you're ready

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-2407-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 3bd50c5 into OCA:15.0 Oct 2, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at db87b3b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-add-base_remote_measure branch October 2, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants