-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][ADD] web_widget_remote_measure: New module #2407
Conversation
Being web client implementation, I think it should be called |
299e51c
to
0e32bef
Compare
Ok, changed :) |
I wonder the overlap with https://odoo-community.org/shop/remote-base-3251?search=remote#attr=21539 and indeed seeing this code, it's including in the same module the base definition with the widget. |
This is also a very specific "remote" thing, so maybe including |
I'd say that module's purpose is to store the accesses to the Odoo server |
It can be extended to a Webservices interface in the future if needed |
Then |
But it could be either webservices or websockets |
OK, I don't insist then. |
0e32bef
to
3bf4cec
Compare
And why not envisaging connecting devices like IOT (that could be connected to POS) and more specifically to pywebdriver ? That allows you to implement protocols there. With the advantage of being available for all flows you want. |
Connection to any remote measure device (IoT or the device itself via web services) would be possible if implemented but we want to keep the infrastructure required to implement this in the customer's setup as simple as possible. For our current approach, adding an IoT (or pywebdriver) in the middle is an extra point of potential failure that can complicate our maintenance. |
So, implementing a particular protocol should maybe go in another module |
23f1267
to
44cb7bd
Compare
44cb7bd
to
a527c20
Compare
95f0027
to
0478ffd
Compare
7ef5746
to
c9a7f61
Compare
c9a7f61
to
47c6999
Compare
Let us know when you're ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! |
This PR has the |
Congratulations, your PR was merged at db87b3b. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT38745
ping @carlosdauden
Example of behavior in the oncoming
stock_remote_device
: