Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] web_group_expand: Migration to 16.0 #2490

Closed
wants to merge 28 commits into from
Closed

[16.0][MIG] web_group_expand: Migration to 16.0 #2490

wants to merge 28 commits into from

Conversation

mayank-ptl
Copy link

No description provided.

mga-odoo and others added 28 commits April 27, 2023 15:07
@mga-odoo
[ADD] New module <web_group_expand>
74145e9
@oihane
[IMP] <web_group_expand> Make it work for v8
1c65088 
Adapt to OCA
@pedrobaeza
[IMP] web_group_expand: Add Jay Vora to credits
8b441d6
@sbidoul
[UPD] prefix versions with 8.0
02170f1
@ivantodorovich
Fix OCA#249
23e0aec
@oca-travis
[UPD] Update web_group_expand.pot
4519143
@janverb
[MIG][12.0] web_group_expand
5cdb22f
@oca-travis
[UPD] Update web_group_expand.pot
c0703ec
@OCA-git-bot
[UPD] README.rst
13f8447
@oca-transbot
Update translation files
970abc3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-12.0/web-12.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_group_expand/
@claudiagn
Added translation using Weblate (Spanish)
a0a9170
@claudiagn
Translated using Weblate (Spanish)
7c413ec 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-12.0/web-12.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_group_expand/es/
@claudiagn
Added translation using Weblate (Catalan)
0ad4e2d
@claudiagn
Translated using Weblate (Catalan)
65aedfe 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-12.0/web-12.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_group_expand/ca/
@marcelsavegnago
Added translation using Weblate (Portuguese (Brazil))
a9cb696
@marcelsavegnago
Translated using Weblate (Portuguese (Brazil))
daf8a69 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-12.0/web-12.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_group_expand/pt_BR/
@manuelcalerosolis
[IMP] web_group_expand: black, isort
a4e30af
@manuelcalerosolis
[MIG] web_group_expand: Migration to 13.0
4825f35
@oca-travis
[UPD] Update web_group_expand.pot
7188066
@OCA-git-bot
[UPD] README.rst
aabec46
[14.0][MIG] web_group_expand
f97999e
@OCA-git-bot
[UPD] README.rst
1768954
@oca-transbot
Update translation files
9df7aad 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-14.0/web-14.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_group_expand/
@Corneliuus
Added translation using Weblate (German)
91fe7a6
@Corneliuus
Translated using Weblate (German)
f3d3046 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-14.0/web-14.0-web_group_expand
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_group_expand/de/
@BT-aestebanez
[MIG] web_group_expand: Migration to 15.0
3c6aa77
[UPD] Update web_group_expand.pot
ec280b0
[MIG] web_group_expand: Migration to 16.0
3608755
@mayank-ptl mayank-ptl mentioned this pull request Apr 27, 2023
Open
45 tasks
CRogos
CRogos approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code + test

Minor issue regarding the migration guide in the commit history:
Missing: "[IMP] web_group_expand: pre-commit stuff"

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

tarteo
tarteo requested changes May 10, 2023
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I tested this locally, there seems to be an issue with the pagination.
If you for example group modules (Apps) by name you get multiple pages of groups:

image

If I go to the next page:
image

And then expand all groups by clicking the button it goes to the first page again.

@dipak-shah
Copy link

I appreciated the efforts behind this migration. It seems like it's been stuck since May. any chance to get this merged? @tarteo @MohamedOsman7 @mayank-ptl

@kikopeiro kikopeiro mentioned this pull request Jul 7, 2023
Open
@CRogos
Copy link
Contributor

CRogos commented Jul 20, 2023

@tarteo do you have an idea how to fix this?

@juliam3991
Copy link

Hello all , I want to extend my gratitude for the hard work and dedication that the team has put into this endeavor. Could you kindly provide an update on the current status of the migration process?

Thank you once again!

@CRogos CRogos mentioned this pull request Aug 29, 2023
Merged
@pedrobaeza
Copy link
Member

Superseded by #2599

@pedrobaeza pedrobaeza closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarteo tarteo tarteo requested changes

@MohamedOsman7 MohamedOsman7 MohamedOsman7 approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.