[16.0][MIG] web_widget_bokeh_chart: Migration to 16.0 #2526
Conversation
OriolMForgeFlow
force-pushed
the
16.0-mig-web_widget_bokeh_chart
branch
9 times, most recently
from
467e3c3 to
e173337
Compare
Avoid "Duplicate explicit target name" error using anonymous hyperlink references Ref.: https://stackoverflow.com/questions/5464627/how-to-have-same-text-in-two-links-with-restructured-text/14067756#14067756
…ontainer element.
…mit dynamic updates
Includes some manual fixes to silent ESLint warnings.
improve the documentation of web_widget_bokeh_chart by providing the required imports to be put in the Python code and fixing the code to so that it works on the version 15 of the module.
OriolMForgeFlow
force-pushed
the
16.0-mig-web_widget_bokeh_chart
branch
2 times, most recently
from
aafb122 to
8b41b6d
Compare
OriolMForgeFlow
force-pushed
the
16.0-mig-web_widget_bokeh_chart
branch
from
8b41b6d to
4639a13
Compare
|
I think I can merge as maintainer of the module, let's see... /ocabot merge nobump |
|
Sorry @LoisRForgeFlow you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@OCA/web-maintainers I guess, the module maintainer merging rights does not work on migrations. Could someone do the honors? Thanks! |
There was a problem hiding this comment.
I think I can merge as maintainer of the module, let's see...
Thanks for porting this usefull module.
Quick question : why do you pin the version bokeh ? AFAIK, the lib is stable, so it could be great to install allways the latest supported version. don't you think or do you see a risk ?
otherwise LGTM.
There was a problem hiding this comment.
@legalsylvain because the pip package need to match the JS assets being added with this module
There was a problem hiding this comment.
oh ! you're right. Thanks.
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 9421ebe. Thanks a lot for contributing to OCA. ❤️ |
No description provided.