[IMP] web_create_write_confirm: fix JS, usage. Minor refactoring. #2576
Conversation
ilyasProgrammer
force-pushed
the
14.0-web_create_write_confirm-fixes
branch
from
afe8f18
to
1dd067b
Compare
|
@simahawk could you please review ? You refactoring changes are here. Also some small JS fixes. |
|
@tarteo fyi :) |
ilyasProgrammer
force-pushed
the
14.0-web_create_write_confirm-fixes
branch
from
1dd067b
to
841db55
Compare
|
@simahawk ping :) |
|
@simahawk in this PR you can find the changes you requested here: #2487 (review) also without this fix a few features in runboat are blocked by this module, so a merge would be very welcome :) |
|
@yajo what do you think? :) |
|
Sorry, I don't know this module and I don't know what this is trying to fix, so I'm not the best one to review here. |
|
@OCA/web-maintainers some runboat features are blocked since this module is displaying errors. This PR fixes it. Can we merge please? |
There was a problem hiding this comment.
functional review on runboat. Something looks broken.
step to reproduce :
-
go to settings / users > create new user
-
click on save.
Error:
Error: event is undefined
ev@http://oca-web-14-0-pr2576-841db5557087.runboat.odoo-community.org/web_create_write_confirm/static/src/js/pop_up_confirmation.js:100:13
display_popup/<@http://oca-web-14-0-pr2576-841db5557087.runboat.odoo-community.org/web_create_write_confirm/static/src/js/pop_up_confirmation.js:93:26
display_popup@http://oca-web-14-0-pr2576-841db5557087.runboat.odoo-community.org/web_create_write_confirm/static/src/js/pop_up_confirmation.js:44:13
_onSave/<@http://oca-web-14-0-pr2576-841db5557087.runboat.odoo-community.org/web_create_write_confirm/static/src/js/pop_up_confirmation.js:29:22```
ilyasProgrammer
force-pushed
the
14.0-web_create_write_confirm-fixes
branch
from
5a45a7e
to
a9f2243
Compare
|
updated |
|
@simahawk when you can. Thanks! |
|
@simahawk what do you say? |
|
/ocabot merge minor |
|
This PR looks fantastic, let's merge it! |
|
This PR has the |
|
Congratulations, your PR was merged at df3a5cc. Thanks a lot for contributing to OCA. ❤️ |
No description provided.