Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web_chatter_position.esm.js #2580

Open
wants to merge 5 commits into
base: 16.0
Choose a base branch
from

Conversation

a-khalil-ecoservice
Copy link

@a-khalil-ecoservice a-khalil-ecoservice commented Aug 2, 2023

when I install the Modul mass_mailing or Knowledge und I will create a new Mailing I get a error when the chatter position is bottom.

when I install the Modul mass_mailing und I will create a new Mailing I get a error when the chatter position is bottom.
@Armitxes
Copy link

Armitxes commented Aug 21, 2023

To help out a bit, I've described the issue - fixes #2596

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Thanks for fixing this !

I'm wondering if this check should be done a few lines above, though, before even cloning the chatterContainerHookXml.

Something like this:

            } else {
                const formSheetBgXml = res.querySelector(".o_form_sheet_bg");
+               if (!formSheetBgXml) {
+                   return res;
+               }
                const sheetBgChatterContainerHookXml =
                    chatterContainerHookXml.cloneNode(true);
                sheetBgChatterContainerHookXml.classList.add("o-isInFormSheetBg");
                sheetBgChatterContainerHookXml.setAttribute("t-if", true);

In any case, I'm not blocking over this.


Could you clean up the commits, though ?
Ideally: keep only one commit, describing the issue that you're fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants