Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] web_save_discard_button module #2594

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

legalsylvain
Copy link
Contributor

First PR : #2577
Code comes from : #2588

  • PR correctly squashed
  • Add french translation

Field are now translatable, thanks to @synconics refactor.

Should be OK to be merged now : CC : @Tardo, @Rad0van

@synconics : here are the command I did to squash the four commits :

git remote rename  origin OCA
git remote add  synconics https://github.com/synconics/web
git remote add  legalsylvain https://github.com/legalsylvain/web
git fetch  synconics 16.0:synconics_16.0
 git checkout synconics_16.0
git rebase -i HEAD~4 
(Squash the four commits, using "s" command)
git pull OCA 16.0 --rebase
git push legalsylvain synconics_16.0

Copy link

@Rad0van Rad0van left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@synconics
Copy link

Hi @Tardo @Rad0van , Should we need to do anything ?

@legalsylvain
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2594-by-legalsylvain-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c4bd2df into OCA:16.0 Aug 23, 2023
4 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f9c8064. Thanks a lot for contributing to OCA. ❤️

@synconics
Copy link

Hi @Tardo @Rad0van @legalsylvain , Merge request was merged more then 2 weeks ago, is there any plan to publish module?

@legalsylvain
Copy link
Contributor Author

Well, publication is automatic, once merged :

@OCA/board : could you take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants