Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] web_timeline: date_delay = date_stop - date_start #2603

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

norlinhenrik
Copy link
Contributor

@norlinhenrik norlinhenrik commented Aug 31, 2023

Adding / Creating a new record, date_delay was hard-coded to always be 1.
Now it computes correctly, if both date_start and date_stop exists.

@OCA-git-bot
Copy link
Contributor

Hi @tarteo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 1, 2023
@pedrobaeza
Copy link
Member

Please pass pre-commit in your local:

https://github.com/OCA/maintainer-tools/wiki/Install-pre-commit

@norlinhenrik norlinhenrik force-pushed the 16.0-fix-web_timeline-date_delay branch from 47590c0 to c253255 Compare September 3, 2023 15:41
@norlinhenrik
Copy link
Contributor Author

Done :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2603-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2ede3b1 into OCA:16.0 Sep 14, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d53cacd. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants