Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] web_responsive: public message chatter color #2610

Merged

Conversation

chienandalu
Copy link
Member

We give a color clue to the users so they can better tell if they're sending an internal note or a public message.

Peek 08-09-2023 10-10

Dislaimer: we use the has() pseudo class mainly because is simpler to implement and the support is quite extended right now. Even Firefox will catch up soon (now it has support behing a config flag).

So users with compatible browser will enjoy it, while others will just stay as they were.

cc @Tecnativa TT44953

please review @carolinafernandez-tecnativa @pedrobaeza

@OCA-git-bot
Copy link
Contributor

Hi @SplashS, @Tardo, @yajo,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 8, 2023
@pedrobaeza
Copy link
Member

Do you know how much time to get it into Firefox?

@pedrobaeza
Copy link
Member

This should go into the README, including the GIF.

@chienandalu chienandalu force-pushed the 15.0-imp-web_responsive-chat-composer-colors branch from f40b509 to db041e3 Compare September 8, 2023 14:58
@chienandalu
Copy link
Member Author

This should go into the README, including the GIF.

Done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked perfectly

We give a color clue to the users so they can better tell if they're
sending an internal note or a public message.

Dislaimer: we use the `has()` pseudo class mainly because is simpler to
implement and the support is quite extended right now. Even Firefox will
catch up soon (now it has support behing a config flag).

So users with compatible browser will enjoy it, while others will just stay
as they were.

TT44953
@chienandalu chienandalu force-pushed the 15.0-imp-web_responsive-chat-composer-colors branch from db041e3 to d0abc2a Compare September 8, 2023 15:02
@chienandalu
Copy link
Member Author

Do you know how much time to get it into Firefox?

I think they're already late on their schedule 😄 https://connect.mozilla.org/t5/ideas/when-is-has-css-selector-going-to-be-fully-implemented-in/idi-p/23794

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not able to enjoy yet (being a Firefox user), it's a good addition.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge patch

Now to v16.

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2610-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a715348 into OCA:15.0 Sep 13, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6e91db7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants