-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] web_responsive: public message chatter color #2610
[15.0][IMP] web_responsive: public message chatter color #2610
Conversation
Do you know how much time to get it into Firefox? |
This should go into the README, including the GIF. |
f40b509
to
db041e3
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked perfectly
We give a color clue to the users so they can better tell if they're sending an internal note or a public message. Dislaimer: we use the `has()` pseudo class mainly because is simpler to implement and the support is quite extended right now. Even Firefox will catch up soon (now it has support behing a config flag). So users with compatible browser will enjoy it, while others will just stay as they were. TT44953
db041e3
to
d0abc2a
Compare
I think they're already late on their schedule 😄 https://connect.mozilla.org/t5/ideas/when-is-has-css-selector-going-to-be-fully-implemented-in/idi-p/23794 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I'm not able to enjoy yet (being a Firefox user), it's a good addition.
This PR has the |
/ocabot merge patch Now to v16. |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 6e91db7. Thanks a lot for contributing to OCA. ❤️ |
We give a color clue to the users so they can better tell if they're sending an internal note or a public message.
Dislaimer: we use the
has()
pseudo class mainly because is simpler to implement and the support is quite extended right now. Even Firefox will catch up soon (now it has support behing a config flag).So users with compatible browser will enjoy it, while others will just stay as they were.
cc @Tecnativa TT44953
please review @carolinafernandez-tecnativa @pedrobaeza