[17.0] [MIG] web_notify #2747

Nikul-OSI · 2024-02-14T06:01:29Z

No description provided.

Nikul-OSI · 2024-02-14T09:35:43Z

Hii @lmignon @pedrobaeza Can you please review this PR?

pedrobaeza · 2024-02-14T09:36:52Z

/ocabot migration web_notify

I don't know enough about the module itself.

Nikul-OSI · 2024-02-14T09:40:57Z

@shepilov-vladislav @kevinkhao @chienandalu Can you please take a look?

lmignon · 2024-02-14T13:04:35Z

@Nikul-OSI Why are all the commit prefixed with [PATCH X/Y]? Can we avoid this prefix?

Nikul-OSI · 2024-02-15T05:17:50Z

commit prefixed with [PATCH X/Y]

@lmignon I captured only preserve history, I don't why it happens.

Using git format-patch --stdout origin/17_mig_nc_web_notify..ups/16.0 -- web_notify | git am -3 --keep

same commend I used others repo. too, but not add prefixed.

…t notification messages from the server to the user in live.

Fix a check when comparing a user count with items within a mock call. The previous method was succeeding by pure luck because OCA test databases contain 2 users, which happens to be the amount of items within a mock "call_args" (it contains args + kwargs).

- Use the 'session' class of the JS Framework (session no lounger bound to web client) - Test change: compare emitted & received messages based on content, not order. Using string comparison raises false positives.

Currently translated at 100,0% (5 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/

Currently translated at 40.0% (2 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/

@hbrunn

Only the admin user (sudo) is allowed to send notifications to other users. The normal users can only send notifications to themselves. This is to prevent attackers to craft malicious notifications and send them to other users using RPC. Correction based on the idea of @hbrunn

…nt, Updated readme to show how to test it. Add buttons to users form Do not rely on SUPERUSER_ID and avoid getattr usage

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

* [ADD]: all available bootstrap notifications (success/danger/warning/info/default) * [IMP] use black color for text for default notification. * [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/

It seems besides the custom channels provided in this addon it also catches messages from other channels. E.g. in this case it seems the void popup is triggered by these activity creation bus messages. **Steps to reproduce** Odoo commit: could reproduce on 5e8b667951 and 4da82776ff OCA/web commit: 2465278 * Install crm and web_notify modules * Create an activity for yourself (tried for admin user) * Empty popup appears **Attempt to solve** It seems the bus handles all messages non exclusively. I've hacked in a conditional to handle only messages from web_notify addon, but its unclear wether this does not break something else.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/

Currently translated at 100.0% (18 of 18 strings) Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/

Currently translated at 94.4% (17 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/it/

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/de/

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/es/

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/it/

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/pt_BR/

When trying to use the notify function that comes from a normal user with sudo flag enabled, it wasn't letting the user access it. Adding the su flag to the check should allow sudo users using this feature.

Nikul-OSI · 2024-02-16T11:02:03Z

@Nikul-OSI Why are all the commit prefixed with [PATCH X/Y]? Can we avoid this prefix?

Fixed Prefix, Ready to review.

kobros-tech · 2024-06-11T18:37:34Z

I can review and contribute as I have made the same upgrade to version 17, but people in OCA sent me this PR so it is better to cooperate to publish it.

I checked all parts that need to be modified in order to make the upgrade successful, and I see they are met.

if the author @Nikul-OSI needs to recheck or inspect my upgrade, here is my module:

https://github.com/kobros-tech/web_notify/tree/main

lbisiach · 2024-07-02T13:03:56Z

@Nikul-OSI Do you estimate when you are going to close this PR ?

Nikul-OSI · 2024-07-03T05:54:40Z

@Nikul-OSI Do you estimate when you are going to close this PR ?

Yes, I reviewed, can you please create new PR. Thank you

nguyenminhchien

UI tests: ok
But, need to move the pre-commit stuff into another commit: [IMP] $module: pre-commit auto fixes. Fyi, https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#tasks-to-do-in-the-migration

chienandalu

Code review ok. However, apply the requested guidelines so its correct in form

pedrobaeza · 2024-10-09T07:23:44Z

Superseded by #2948

Nikul-OSI mentioned this pull request Feb 14, 2024

Migration to version 17.0 #2661

Open

26 tasks

murtuzasaleh mentioned this pull request Feb 14, 2024

[17.0][MIG] base_phone_popup OCA/connector-telephony#310

Open

Nikul-OSI force-pushed the 17_mig_nc_web_notify branch from 7540664 to 1e7ddfe Compare February 14, 2024 09:34

OCA-git-bot added this to the 17.0 milestone Feb 14, 2024

Nikul-OSI force-pushed the 17_mig_nc_web_notify branch from 1e7ddfe to 34a29ff Compare February 14, 2024 09:55

shepilov-vladislav approved these changes Feb 15, 2024

View reviewed changes

lmignon and others added 19 commits February 16, 2024 16:29

New module web_notify This technical module allows you to send instan…

49c6674

…t notification messages from the server to the user in live.

Make modules uninstallable

5185c80

Migration started web_notify

16d8cb0

Return result of super of show_application

2bf3c51

Update web_client.js

fcc05a9

OCA Transbot updated translations from Transifex

3a4057a

web_notify: Migration to 11.0

909a2da

- Use the 'session' class of the JS Framework (session no lounger bound to web client) - Test change: compare emitted & received messages based on content, not order. Using string comparison raises false positives.

Translated using Weblate (Portuguese (Brazil))

93d996c

Currently translated at 100,0% (5 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/

Translated using Weblate (Danish)

6a0a97c

Currently translated at 40.0% (2 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/

web_notify: Migration to 12.0 Add self-test buttons in demo environme…

2079492

…nt, Updated readme to show how to test it. Add buttons to users form Do not rely on SUPERUSER_ID and avoid getattr usage

Update translation files

3392f1d

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

README.rst

6533132

Update translation files

613b892

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/

Update translation files

7e29d72

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/

README.rst

ca22247

OCA-git-bot and others added 19 commits February 16, 2024 16:29

README.rst

5abcba4

Update translation files

be80f93

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/

Added translation using Weblate (Italian)

854c7c8

Translated using Weblate (Italian)

f65ba1b

Currently translated at 100.0% (18 of 18 strings) Translation: web-15.0/web-15.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_notify/it/

web_notify: Migration to 16.0

95246a8

web_notify: if not target then take self.partner_id

20efcf2

show message under html format

238d243

Update web_notify.pot

1f09445

README.rst

0c6da44

Update translation files

b78b43c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/

Translated using Weblate (Italian)

0eaf595

Currently translated at 94.4% (17 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/it/

Translated using Weblate (German)

7b2302a

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/de/

Translated using Weblate (Spanish)

f18e83b

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/es/

README.rst

1ac6dfc

Translated using Weblate (Italian)

e71fd64

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/it/

Translated using Weblate (Portuguese (Brazil))

18ccfaa

Currently translated at 100.0% (18 of 18 strings) Translation: web-16.0/web-16.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_notify/pt_BR/

web_notify

686c0e0

When trying to use the notify function that comes from a normal user with sudo flag enabled, it wasn't letting the user access it. Adding the su flag to the check should allow sudo users using this feature.

post-merge updates

6a28885

[MIG] web_notify: Migrated in v17

2e5d264

Nikul-OSI force-pushed the 17_mig_nc_web_notify branch from 34a29ff to 2e5d264 Compare February 16, 2024 11:00

nguyenminhchien suggested changes Jul 24, 2024

View reviewed changes

chienandalu suggested changes Aug 12, 2024

View reviewed changes

JasminSForgeFlow mentioned this pull request Sep 18, 2024

[17.0][MIG] web_notify_channel_message #2931

Open

trisdoan mentioned this pull request Oct 9, 2024

[17.0][MIG] web_notify: Migration to 17.0 #2948

Merged

pedrobaeza closed this Oct 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0] [MIG] web_notify #2747

[17.0] [MIG] web_notify #2747

Nikul-OSI commented Feb 14, 2024

Nikul-OSI commented Feb 14, 2024

pedrobaeza commented Feb 14, 2024

Nikul-OSI commented Feb 14, 2024

lmignon commented Feb 14, 2024

Nikul-OSI commented Feb 15, 2024

Nikul-OSI commented Feb 16, 2024

kobros-tech commented Jun 11, 2024

lbisiach commented Jul 2, 2024

Nikul-OSI commented Jul 3, 2024

nguyenminhchien left a comment •

edited

Loading

chienandalu left a comment

pedrobaeza commented Oct 9, 2024

[17.0] [MIG] web_notify #2747

[17.0] [MIG] web_notify #2747

Conversation

Nikul-OSI commented Feb 14, 2024

Nikul-OSI commented Feb 14, 2024

pedrobaeza commented Feb 14, 2024

Nikul-OSI commented Feb 14, 2024

lmignon commented Feb 14, 2024

Nikul-OSI commented Feb 15, 2024

Nikul-OSI commented Feb 16, 2024

kobros-tech commented Jun 11, 2024

lbisiach commented Jul 2, 2024

Nikul-OSI commented Jul 3, 2024

nguyenminhchien left a comment • edited Loading

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 9, 2024

nguyenminhchien left a comment •

edited

Loading