Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] web_m2x_options: add fieldColor to KanbanMany2ManyTagsAvatarField #2959

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

JordiMForgeFlow
Copy link

Fixes new issued identified in #2934

Based on same fixes applied on #2921

CC @CRogos @chienandalu @pedrobaeza

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if there's a generic way to do that, as I already stated before.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could avoid some boilerplate code using a common object. Somethin like:

const fieldColorProps = {
    fieldColor: {type: String, optional: true},
    fieldColorOptions: {type: Object, optional: true},
}

//...

WhatEverField.props = {
    ...WhatEverField.props,
    ...fieldColorProps,
};

@JordiMForgeFlow
Copy link
Author

Maybe we could avoid some boilerplate code using a common object. Somethin like:

const fieldColorProps = {
    fieldColor: {type: String, optional: true},
    fieldColorOptions: {type: Object, optional: true},
}

//...

WhatEverField.props = {
    ...WhatEverField.props,
    ...fieldColorProps,
};

Makes sense, changes applied! :)

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

This is still requiring to inherit each widget. I meant a way to do it on the "base", but anyway, let's merge meanwhile:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-2959-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 777ea72 into OCA:17.0 Oct 16, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6dbc334. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants