-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FIX] web_m2x_options: add fieldColor to KanbanMany2ManyTagsAvatarField #2959
[17.0][FIX] web_m2x_options: add fieldColor to KanbanMany2ManyTagsAvatarField #2959
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a generic way to do that, as I already stated before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could avoid some boilerplate code using a common object. Somethin like:
const fieldColorProps = {
fieldColor: {type: String, optional: true},
fieldColorOptions: {type: Object, optional: true},
}
//...
WhatEverField.props = {
...WhatEverField.props,
...fieldColorProps,
};
Makes sense, changes applied! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This is still requiring to inherit each widget. I meant a way to do it on the "base", but anyway, let's merge meanwhile: /ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 6dbc334. Thanks a lot for contributing to OCA. ❤️ |
Fixes new issued identified in #2934
Based on same fixes applied on #2921
CC @CRogos @chienandalu @pedrobaeza