[18.0][MIG] web_tree_dynamic_colored_field: Migration to 18.0 #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support color_field attribute update manifest higher version number bump typo
demo view
The options in <field> attributes are parsed as python expressions: https://github.com/odoo/odoo/blob/d18976d7489f6cd1c904f72557104807233a178d/addons/web/static/src/js/services/data_manager.js#L273 And the options in <button> are parsed as json... https://github.com/odoo/odoo/blob/d18976d7489f6cd1c904f72557104807233a178d/addons/web/static/src/js/services/data_manager.js#L411 This code only support the <field> element because I'm not sure there is a use for the <button> element.
…'color_field'
The index at 0 in the following code:
var colorField = this.arch.attrs.colors.split(';')
.filter(color => color.trim().startsWith('color_field'))[0]
Was failing on such valid xml:
<tree string="Buffer monitor"
colors="red:procure_recommended_qty > 0">
Use more than one color condition
Found in this commit: OCA@3965057
Use 'options' instead of 'colors' on tree views The colors attribute has been removed from the RelaxNG schema in Odoo [0], so use the 'options' instead. Closes OCA#1479 [0] odoo/odoo@7024f8d#diff-e9acd2f731cc01f302055b6e232df983
The 'colors' and 'options' fields are not supported by the RelaxNG schema of the <tree> element. Remove the support until we find a good solution for this.
[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-13.0/web-13.0-web_tree_dynamic_colored_field Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_tree_dynamic_colored_field/
[UPD] README.rst
[UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_tree_dynamic_colored_field Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_tree_dynamic_colored_field/ Added translation using Weblate (French)
- Implementation now is based on updating `style` attribute of `cell/td` instead of manipulating element's `css` value in js. - Cleanup docs about no more functioning `colors` parameter for `tree` (since 13.0)
This was referenced Oct 16, 2024
ivantodorovich
approved these changes
Nov 4, 2024
|
This PR has the |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 3dffef4. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.