-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][IMP] web_timeline: Update vis-timeline-graph2d lib: 7.7.0 -> 7.7.3 #2972
Conversation
Hi @tarteo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't the diff much larger than needed? I don't see that many changes in the related release notes 🤔 for example, looks like css stuff is just moved from one place to another in the css file...
@@ -889,6 +889,21 @@ | |||
border-style: solid; | |||
border-radius: 4px; | |||
} | |||
.vis .overlay { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why increasing the diff moving the styles ?
Yes, and the library JS seems also very different. Maybe one version is minified and the other not? |
I only copied the files generated by executing the |
Well, it's the double in fact (48k additions instead of 24k). Not sure if there can be any command line for changing somehow the result. |
I'm not sure, but if @chienandalu or @CarlosRoca13 can help me with the command used in the previous case, that would be great. The difference is mainly in the indentation. |
That's not hard to deal with. Just select the whole block and indent it to the right :) |
Ah, ok. In that case I think is ok :) I just saw your first capture where all the code was pulled to the left |
Can't you configure a different indentation or open it and change it for minimizing the diff? |
4f75d9f
to
5feee78
Compare
I took the file directly from https://unpkg.com/[email protected]/standalone/umd/vis-timeline-graph2d.js |
Are we sure the next time it will be indented the same way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the diff seems to not be avoidable, let's merge it:
/ocabot merge patch
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 6b62ffb. Thanks a lot for contributing to OCA. ❤️ |
no breakchanges, see https://github.com/visjs/vis-timeline/releases/tag/v7.7.3
TT50999
@Tecnativa @pedrobaeza @CarlosRoca13 @chienandalu could you please review this