Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] web_datetime_picker_default_time: Migration to 18.0 #3024

Open
wants to merge 8 commits into
base: 18.0
Choose a base branch
from

Conversation

natuan9
Copy link

@natuan9 natuan9 commented Dec 18, 2024

No description provided.

@natuan9 natuan9 mentioned this pull request Dec 18, 2024
26 tasks
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

It's a shame we don't have unit tests, though.
How do you feel about adding some?

@natuan9 natuan9 force-pushed the 18.0-mig-web_datetime_picker_default_time branch from 5b6b95e to 39dc87c Compare January 15, 2025 09:00
@natuan9
Copy link
Author

natuan9 commented Jan 20, 2025

Hi @ivantodorovich , I added some test cases for this module.

Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

As far as I remember, and as far as I can see on the CI logs, we need to explicitly execute these tests from a python test.

Here's an example on a 16.0 module: https://github.com/OCA/web/blob/16.0/web_domain_field/tests/test_qunit.py

@@ -191,7 +191,7 @@ const config = [{
},

}, {
files: ["**/*.esm.js"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are synchronized from time to time from the https://github.com/oca/oca-addons-repo-template
This change will then be lost..

I recommend to simply use the .test.esm.js suffix on your filename, then it'd be selected by this existing pattern

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried using the suffix .test.esm.js, but Hoot doesn't work with this file extension. The guy in this video mentioned that test files must end with .test.js.
Test your JS Code with Hoot
image

Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but setting of default time while entering manually the date with keyboard does not work. (it used to in v16.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants