[17.0][IMP] web_company_color: apply colors in debug assets and edit menu colors #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure, but should it be showing the options in any different color? |
…olors Allow each company's colors to be visible when running in debug assets mode. Fix the menu colors so they don't look like hyperlinks.
ThiagoMForgeFlow
force-pushed
the
17.0-imp-web_company_color
branch
from
338a02d to
e56871c
Compare
You're right. With the latest changes, if no value is set for Link Text Color, the submenus do not appear as hyperlinks, but the other elements do. And when a value is chosen for Link Text Color, everything uses that value. Thank you |
CarlosRoca13
approved these changes
Jan 10, 2025
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 935eab6. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow each company's colors to be visible when running in debug assets mode. Fix the menu colors so they don't look like hyperlinks.
@ForgeFlow
@CarlosRoca13