[MIG] website_local_font: Migration to 16.0 #1051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reyes4711-S73
changed the title
Reyes4711-S73
force-pushed
the
16.016.0-mig-website_local_font-def
branch
from
b097857 to
4a24839
Compare
|
/ocabot migration website_local_font |
Reyes4711-S73
force-pushed
the
16.016.0-mig-website_local_font-def
branch
from
4a24839 to
84f2984
Compare
|
@xaviedoanhduy Done |
xaviedoanhduy
approved these changes
Sep 30, 2024
|
Thanks for this @Reyes4711-S73 , do you mind rebasing so we can test it on runboat? |
Reyes4711-S73
force-pushed
the
16.016.0-mig-website_local_font-def
branch
2 times, most recently
from
f559526 to
f01dfab
Compare
[ADD] website_local_fonts: add new module [ADD] website_local_fonts: add new module Updated Test Folder Name Changes as per suggestions in the PR Added missing setup file
Reyes4711-S73
force-pushed
the
16.016.0-mig-website_local_font-def
branch
from
f01dfab to
a9b0f21
Compare
Christian-RB
approved these changes
Jan 29, 2025
|
This PR has the |
|
LGTM! It allows you to import local fonts that are not from Google, the only aspect I detected is that it duplicates and adds the Google fonts, which is already included in Odoo. |
Abimael1321
approved these changes
Jan 29, 2025
AlvRM2002
suggested changes
Jan 30, 2025
Comment on lines
+90
to
+96
| $(this.menuEl).append( | ||
| $( | ||
| core.qweb.render("website.add_google_font_btn", { | ||
| variable: variable, | ||
| }) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
In order to avoid the duplication of the 'Add Google Fonts' button, you should remove these lines.
Suggested change
| $(this.menuEl).append( | |
| $( | |
| core.qweb.render("website.add_google_font_btn", { | |
| variable: variable, | |
| }) | |
| ) | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration to 16.0
Reopen from #1028