Fix warnings

OCHA-DAP · Feb 13, 2025 · 7dfa819 · 7dfa819
1 parent f0a31e3
commit 7dfa819
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 79 deletions.
diff --git a/requirements-test.txt b/requirements-test.txt
@@ -31,7 +31,7 @@ click==8.1.8
     # via
     #   -c requirements.txt
     #   typer
-coverage==7.6.11
+coverage==7.6.12
     # via pytest-cov
 defopt==6.4.0
     # via
@@ -157,7 +157,7 @@ num2words==0.5.14
     # via
     #   -c requirements.txt
     #   quantulum3
-numpy==2.2.2
+numpy==2.2.3
     # via
     #   -c requirements.txt
     #   pandas

diff --git a/requirements.txt b/requirements.txt
@@ -87,7 +87,7 @@ more-itertools==10.6.0
     # via inflect
 num2words==0.5.14
     # via quantulum3
-numpy==2.2.2
+numpy==2.2.3
     # via pandas
 openpyxl==3.1.5
     # via hdx-python-utilities

diff --git a/src/hdx/scraper/acled/acled.py b/src/hdx/scraper/acled/acled.py
@@ -128,23 +128,18 @@ def download_data(self, current_year: int) -> None:
                     end_dates.append(end_date)
 
                     # Fill in pcodes and names
-                    warning = None
                     if admin_level == 0:
                         adm1_pcodes.append(None)
                         adm2_pcodes.append(None)
                         adm1_names.append(None)
                         adm2_names.append(None)
+                        warnings.append(None)
 
+                    warning = None
                     if admin_level == 2:
                         pcode = contents["Admin2 Pcode"][i]
                         admin2_name = contents["Admin2"][i]
                         if not pcode:
-                            self._error_handler.add_missing_value_message(
-                                "ACLED",
-                                dataset_name,
-                                f"admin {admin_level} pcode",
-                                admin2_name,
-                            )
                             warning = f"Missing pcode for {admin2_name}!"
                         elif pcode not in self._admins[1].pcodes:
                             matched_pcode = self._admins[1].convert_admin_pcode_length(
@@ -199,6 +194,7 @@ def download_data(self, current_year: int) -> None:
                 contents["admin2_code"] = adm2_pcodes
                 contents["admin1_name"] = adm1_names
                 contents["admin2_name"] = adm2_names
+                contents["warning"] = warnings
 
                 # Add fatalities column
                 if "Fatalities" not in headers: