Revert "NZSL-167: Presign asset requests" #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooke-m
approved these changes
Jan 17, 2024
joshmcarthur
deleted the
revert-1524-task/nzsl-167-presign-sign-asset-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #1524. We have determined that private assets should never be presented from prerelease databases, and while the ability to export such videos from NZSL Signbank has already been removed, we want to ensure that it's not possible to present these videos by removing the ability to presign asset URLs within NZSL Dictionary.
This reversion means that the behaviour of the app will revert to using the asset URL as it is provided in the export, which should be publicly available in the S3 bucket.