Skip to content

Commit

Permalink
[Vk] Fix warnings
Browse files Browse the repository at this point in the history
"delete called on non-final 'Ogre::VulkanCache' that has virtual
functions but non-virtual destructor."

This was introduced due to deriving from VulkanDeviceResource for device
lost handling.
  • Loading branch information
darksylinc committed Dec 7, 2024
1 parent 9120d32 commit 498e0f9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion RenderSystems/Vulkan/include/OgreVulkanCache.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ namespace Ogre
{
/**
*/
class _OgreVulkanExport VulkanCache : public OgreAllocatedObj, protected VulkanDeviceResource
class _OgreVulkanExport VulkanCache final : public OgreAllocatedObj, protected VulkanDeviceResource
{
protected:
struct VkRenderPassCreateInfoCmp
Expand Down
4 changes: 2 additions & 2 deletions RenderSystems/Vulkan/include/OgreVulkanDiscardBufferManager.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ namespace Ogre
///
/// We need Discard for the v1 interfaces. So we need to emulate it.
/// This class does exactly this.
class _OgreVulkanExport VulkanDiscardBufferManager : public OgreAllocatedObj,
protected VulkanDeviceResource
class _OgreVulkanExport VulkanDiscardBufferManager final : public OgreAllocatedObj,
protected VulkanDeviceResource
{
public:
struct UnsafeBlock : public VulkanVaoManager::Block
Expand Down

0 comments on commit 498e0f9

Please sign in to comment.