feat(SR): SCOORD3D point annotations support for stack viewport

[igoroctaviano]

• Support for SCOORD3D point annotations (just rendering / no hydration)
• Support for SCT finding site (rendering labels to point and panel)
• Support to render untracked findings to the measurement panel in a new section so the user can interact (jump to measurement) even if it's not being tracked
• Support to render the same measurement to a different image id by frame of reference
• Related PR: fix(state manager): Make viewport-related data optional for annotation event cornerstonejs/cornerstone3D#950
• Issue: Add DICOM SR Support for additional/common annotations #1215

Context

Former PRs:

• WIP fix(SR): Fix/sr SCOORD3D not loading #3631

#planar

Changes & Results

Testing

Checklist

PR

• [] My Pull Request title is descriptive, accurate and follows the
  semantic-release format and guidelines.

Code

• [] My code has been well-documented (function documentation, inline comments,
  etc.)

Public Documentation Updates

• [] The documentation page has been updated as necessary for any public API
  additions or removals.

Tested Environment

• [] OS:
• [] Node version:
• [] Browser:

[netlify]

✅ Deploy Preview for ohif-platform-docs ready!

Name	Link
🔨 Latest commit	0a985d1
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/66981a34fc52950008a70907
😎 Deploy Preview	https://deploy-preview-3857--ohif-platform-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

❌ Deploy Preview for ohif-dev failed. Why did it fail? →

Name	Link
🔨 Latest commit	0a985d1
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/66981a341846f600075d8adb

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a2a0090) 44.44% compared to head (4d83134) 44.44%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3857   +/-   ##
=======================================
  Coverage   44.44%   44.44%           
=======================================
  Files          80       80           
  Lines        1332     1332           
  Branches      327      327           
=======================================
  Hits          592      592           
  Misses        587      587           
  Partials      153      153           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a0090...4d83134. Read the comment docs.

[igoroctaviano]

@sedghi can you take a look at these changes and let me know what you think? This allows the rendering of scoord3d points by FOR. There's another PR here that is related: cornerstonejs/cornerstone3D#950
I tried to keep the changes to a minimum without impacting existent functioanlity.

[cypress]

Passing run #4004 ↗︎

0

43

0

0

0

Details:

CR Update
Project: Viewers	Commit: 6033d3eda8
Status: Passed	Duration: 05:03 💡
Started: May 28, 2024 4:46 PM	Ended: May 28, 2024 4:51 PM

Review all test suite changes for PR #3857 ↗︎

[sedghi]

This seems to be a special measurement since it has coordinates. Can we call it SRMeasurement then?

[fedorov]

@igoroctaviano do we have an instance that can be pointed to a Google DICOM Store to test this functionality?

[igoroctaviano]

@fedorov We don't but you can quickly test it locally using your OIDC config and http://localhost:3000/projects/idc-sandbox-000/locations/us/datasets/idc-dicom-test-inventory/dicomStores/test-samples/study/1.3.6.1.4.1.14519.5.2.1.7310.5101.860473186348887719777907797922.

In my last discussion with the OHIF team, they mentioned that this PR would need some modifications to be merged, such as adding a new Cornerstone scoord3d point tool and adapter to cornertone instead of using OHIF's DICOM SR display tool. Unfortunately, we don't have the time/resources to implement these changes at this moment.

[fedorov]

you can quickly test it locally using your OIDC config

I am not quite sure what this means. But in any case, since there is no plan to make this available any time soon, and it will be reimplemented anyway, it is not worth it to spend time testing. It is unfortunate that after investing so much into developing this functionality from the IDC side, it is still in this state ...

[igoroctaviano]

you can quickly test it locally using your OIDC config

I am not quite sure what this means. But in any case, since there is no plan to make this available any time soon, and it will be reimplemented anyway, it is not worth it to spend time testing. It is unfortunate that after investing so much into developing this functionality from the IDC side, it is still in this state ...

I agree. The PR got approved at some point but things changed on the OHIF side. I'll leave the PR open since SCOORD3D support might be another project's common interest.

[wayfarer3130]

Could you test this with the changes for Viewports for Video and WSI? Much of the same jump to point capabilities were added as a core part of CS3D recently, and then supported in OHIF using the setViewReference capabilities. I'm not sure how much is still needed, and what other parts are still needed.
The viewport PR is #4182
Could we arrange some time to meet and discuss this?