[DONT MERGE] Trying new cornerstone3d 2.0 with the recent release #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Viewers
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/3.8-cs-next
|
| Run status |
|
| Run duration | 06m 25s |
| Commit |
|
| Committer | Alireza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
42
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
study-list/OHIFStudyList.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Study List > Desktop resolution > maintains Patient Name filter upon return from viewer |
Test Replay
Screenshots
Video
|
|
ImageConsistency.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| CS3D Image Consistency and Quality > TG18 Resolution Test Displayed 1:1 |
Test Replay
Screenshots
Video
|
|
chore: Enable stack context prefetch on new stack events chore: Update measurement unit properties to match new naming conventions chore: Update TypeScript dependency to version 5.5.4 chore: Update TypeScript dependency to version 5.5.4 chore: Fix typo in SegmentationService.ts
sedghi
force-pushed
the
feat/3.8-cs-next
branch
from
7e9555b
to
d6c4c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to migrate ohif to new upcoming cornerstone3D 2.0 with the migration guides from here cornerstonejs/cornerstone3D#1400
Todo:
segmentationGroupproperty to the hanging protocol. This allows hanging protocols to determine which viewports should be rendered together. This feature is particularly useful in scenarios like MPR (Multiplanar Reconstruction) and TMTV (Total Metabolic Tumor Volume), where a segmentation needs to be displayed across multiple viewports.