Create API for map pins search #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3955
|
| Run status |
|
| Run duration | 05m 24s |
| Commit |
|
| Committer | unknown |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
75
|
| View all changes introduced in this branch ↗︎ | |
src/routes/api.mappins.$id.ts
Outdated
| // taken from platform-api | ||
| async function getUserProfile(userId) { | ||
| const collectionRef1 = collection(firestore, DB_ENDPOINTS.users) | ||
| const usersQuery1 = query(collectionRef1, where('_authId', '==', userId)) |
There was a problem hiding this comment.
@benfurber do you know why we need to query for _authId?
There was a problem hiding this comment.
I believe _authId relates to the auth stuff which is linked to a user recond on sign-up. Not sure why it's needed here...
src/routes/api.mappins.ts
Outdated
| // check if cached map pins are availbe, if not - load from db and cache them | ||
| if (cachedMappins) { | ||
| return json({ mapPins: cachedMappins }) | ||
| } else { |
There was a problem hiding this comment.
no need the else since the if returns
src/routes/api.mappins.$id.ts
Outdated
| return queryResults1.docs[0].data() | ||
| } | ||
|
|
||
| const collectionRef2 = collection(firestore, DB_ENDPOINTS.users) |
There was a problem hiding this comment.
if querying for _authId is really needed, the collection is the same, so we don't need a "collectionRef2"
src/routes/api.mappins.$id.ts
Outdated
Comment on lines
81
to
82
| const usersQuery2 = query(collectionRef2, where('_id', '==', userId)) | ||
| const queryResults2 = await getDocs(usersQuery2) |
There was a problem hiding this comment.
if querying for _authId is really needed, can still make the code more readable:
const usersCollection = collection(firestore, DB_ENDPOINTS.users);
const usersByAuthId = await getDocs(query(usersCollection, where('_authId', '==', userId)));
const usersById = await getDocs(query(usersCollection, where('_id', '==', userId)));
mariojsnunes
approved these changes
Oct 30, 2024
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
map pins fetched from the old API (platfrom-api)
What is the new behavior?
map pins is fetching using Remix backend API
Does this PR introduce a breaking change?
Git Issues
Closes #3916
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.