Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: pr preview workflow improvements #3974

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

iSCJT
Copy link
Contributor

@iSCJT iSCJT commented Oct 30, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Same workflow was handling pr's that were closed as well as labelled

What is the new behavior?

Separated concerns so that separate workflow handling pr's that are closed and improved naming of workflows

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@iSCJT iSCJT requested a review from a team as a code owner October 30, 2024 10:47
@iSCJT iSCJT merged commit 5a1a204 into master Oct 30, 2024
4 of 10 checks passed
@iSCJT iSCJT deleted the build/more-gh-workflow branch October 30, 2024 10:47
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants