chore: rename all library functions #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please hold off this PR until #4053 is merged |
benfurber
force-pushed
the
chore/howto-to-library-naming/functions
branch
from
42a5eb1 to
7355285
Compare
mariojsnunes
approved these changes
Jan 20, 2025
benfurber
force-pushed
the
chore/howto-to-library-naming/functions
branch
2 times, most recently
from
b3f58c8 to
40a578d
Compare
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4073
|
| Run status |
|
| Run duration | 05m 26s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
79
|
| View all changes introduced in this branch ↗︎ | |
benfurber
force-pushed
the
chore/howto-to-library-naming/functions
branch
from
40a578d to
94c7264
Compare
benfurber
force-pushed
the
chore/howto-to-library-naming/functions
branch
from
94c7264 to
dea0bb4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4073 +/- ##
=======================================
Coverage 69.66% 69.66%
=======================================
Files 39 39
Lines 1236 1236
Branches 258 258
=======================================
Hits 861 861
Misses 353 353
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes
Does this PR introduce a breaking change?
Git Issues
Closes #
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.