Accordion component #4080
Open
Accordion component #4080
+92
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The 'Current Email' subtitle doesn't have the underline anymore. I wasn't sure how to add it without making a specific case just for the email form. |
benfurber
requested changes
Jan 17, 2025
There was a problem hiding this comment.
Awesome! Thanks @CrowsVeldt. A few minor bits, plus you need to run yarn format.
| } as Meta<typeof Accordion> | ||
|
|
||
| export const Default: StoryFn<typeof Accordion> = () => ( | ||
| <Accordion title="Default"> |
There was a problem hiding this comment.
It make this a little more meaningful, how's about the title of 'Accordion Title'
|
|
||
| export const Default: StoryFn<typeof Accordion> = () => ( | ||
| <Accordion title="Default"> | ||
| <Text>Default</Text> |
There was a problem hiding this comment.
And change this to 'Now you see me!'
Comment on lines
+12
to
+17
| const { getByText } = render( | ||
| <Default {...(Default.args as IProps)} />, | ||
| ) | ||
|
|
||
| expect(getByText('Accordion')).toBeInTheDocument(); | ||
| }) |
There was a problem hiding this comment.
Probably something like this would be good:
it('displays the accordion body on click', () => {
const { getByText } = render(
<Default {...(Default.args as IProps)} />,
)
const accordionTitle = getByText('Accordion Title')
expect(getByText('Now you see me!')).not.toBeInTheDocument()
accordionTitle.click()
expect(getByText('Now you see me!')).toBeInTheDocument()
| @@ -76,3 +76,4 @@ export { VideoPlayer } from './VideoPlayer/VideoPlayer' | |||
| export { CommentAvatar } from './CommentAvatar/CommentAvatar' | |||
| export type { availableGlyphs } from './Icon/types' | |||
| export type { ITab } from './SettingsFormWrapper/SettingsFormTab' | |||
| export { Accordion } from './Accordion/Accordion' | |||
There was a problem hiding this comment.
If you wanted to be really nice, could you put this in alphabetical order please. :)
benfurber
force-pushed
the
accordion-component
branch
from
cc7f3d5 to
d48ab53
Compare
benfurber
added
the
Review allow-preview ✅
|
@CrowsVeldt Just QA'd it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes
Does this PR introduce a breaking change?
Git Issues
Closes #3786
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.