Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typing and fields for categories #4091

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the new behavior?

Adds a missing field for categories and updates the typing so it's now shared.

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

@benfurber benfurber force-pushed the fix/category-typing branch 7 times, most recently from e8c0b90 to 0e3d1ed Compare January 21, 2025 14:05
Copy link

cypress bot commented Jan 21, 2025

onearmy-community-platform    Run #6815

Run Properties:  status check passed Passed #6815  •  git commit 86fcc953c4: chore: tidy-up further category typing
Project onearmy-community-platform
Branch Review pull/4091
Run status status check passed Passed #6815
Run duration 05m 37s
Commit git commit 86fcc953c4: chore: tidy-up further category typing
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

@benfurber benfurber force-pushed the fix/category-typing branch from 0e3d1ed to cb363b0 Compare January 21, 2025 14:28
@benfurber benfurber force-pushed the fix/category-typing branch from fa7147e to 19fbd4e Compare January 21, 2025 16:58
@benfurber benfurber force-pushed the fix/category-typing branch 3 times, most recently from e816dd7 to 3b7894e Compare January 22, 2025 10:11
@benfurber benfurber force-pushed the fix/category-typing branch from 3b7894e to 86fcc95 Compare January 22, 2025 10:50
@benfurber benfurber merged commit 8e6148c into ONEARMY:master Jan 22, 2025
18 checks passed
@benfurber benfurber deleted the fix/category-typing branch January 22, 2025 11:05
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants