-
-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typing and fields for categories #4091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
force-pushed
the
fix/category-typing
branch
from
January 20, 2025 14:01
1d5ba02
to
ba9fcb8
Compare
supabase/migrations/20250120115148_add_deleted_to_categories_table.sql
Outdated
Show resolved
Hide resolved
benfurber
force-pushed
the
fix/category-typing
branch
7 times, most recently
from
January 21, 2025 14:05
e8c0b90
to
0e3d1ed
Compare
onearmy-community-platform Run #6815
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/4091
|
Run status |
Passed #6815
|
Run duration | 05m 37s |
Commit |
86fcc953c4: chore: tidy-up further category typing
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
79
|
View all changes introduced in this branch ↗︎ |
benfurber
force-pushed
the
fix/category-typing
branch
from
January 21, 2025 14:28
0e3d1ed
to
cb363b0
Compare
benfurber
force-pushed
the
fix/category-typing
branch
from
January 21, 2025 16:58
fa7147e
to
19fbd4e
Compare
mariojsnunes
approved these changes
Jan 21, 2025
benfurber
force-pushed
the
fix/category-typing
branch
3 times, most recently
from
January 22, 2025 10:11
e816dd7
to
3b7894e
Compare
benfurber
force-pushed
the
fix/category-typing
branch
from
January 22, 2025 10:50
3b7894e
to
86fcc95
Compare
🎉 This PR is included in version 2.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Adds a missing field for categories and updates the typing so it's now shared.
Does this PR introduce a DB Schema Change or Migration?