Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/leeway #768

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Feature/leeway #768

merged 3 commits into from
Feb 25, 2023

Conversation

LinneyS
Copy link
Member

@LinneyS LinneyS commented Feb 25, 2023

Extra leeway time for clock skew

Thank's @anon8675309 #729

anon8675309 and others added 3 commits February 25, 2023 15:14
If the system clock of the document server is even a second slower than the
nextcloud server, the JWT token will be rejected as being "not yet valid". This
can be seen in the logs (Nextcloud -> Settings -> Administration -> Logging).

The error message shown to the user when this happens is more generic:

"Error when trying to connect (Error occurred in the document service: Error
while downloading the document file to be converted.)"

This error message has been reported on the bug tracker several times, but it is
not clear when the connection failure was due to imperfectly synchronized clocks
and when it was due to network connectivity, DNS issues, the JWT not being sent,
the secret being wrong, or some other issue.

Here are the tickets that may be fixed by this:
#345
#548
#315
#290
#127

There's also one on the owncloud fork that may be fixed by this as well:
ONLYOFFICE/onlyoffice-owncloud#278
@LinneyS LinneyS merged commit 8c6a01d into develop Feb 25, 2023
@LinneyS LinneyS deleted the feature/leeway branch February 25, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant