Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use utils datetime function #45

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update to use utils datetime function #45

merged 1 commit into from
Jul 10, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented Jul 10, 2024 •
edited
Loading

Summary

Update to call existing datetime function when cleaning data and changing data types

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@Jday7879 Jday7879 added the enhancement New feature or request label Jul 10, 2024
@Jday7879 Jday7879 linked an issue Jul 10, 2024 that may be closed by this pull request
Refactor to use developed datetime function #44
Closed
@Jday7879 Jday7879 requested a review from AntonZogk July 10, 2024 10:10
@Jday7879 Jday7879 marked this pull request as ready for review July 10, 2024 10:12
@AntonZogk
Copy link
Collaborator

All looking good :) , happy to be merged

@Jday7879 Jday7879 merged commit 2bb86c4 into main Jul 10, 2024
3 checks passed
@Jday7879 Jday7879 deleted the 44-refactor-to-use-developed-datetime-function branch July 10, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonZogk AntonZogk AntonZogk approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor to use developed datetime function
2 participants
@Jday7879 @AntonZogk