Refactor connection to it's own Host Object #77
Conversation
cpp/OpenSqliteHo.h
Outdated
|
|
||
| namespace opsqlite { | ||
|
|
||
| class JSI_EXPORT OpenSqliteHo : public facebook::jsi::HostObject { |
There was a problem hiding this comment.
Rename to DbHostObject
There was a problem hiding this comment.
Please use the namespace jsi = facebook::jsi to avoid long lines
cpp/OpenSqliteHo.cpp
Outdated
|
|
||
| jsi::Function OpenSqliteHo::open(jsi::Runtime &rt, | ||
| const std::string &basePath) { | ||
| return HOSTFN("open", 3) { |
There was a problem hiding this comment.
In case you still need some help: You are kinda on the right path, but this is not quite correct. You need the get, set and getPropertyNames function for the HostObject to work. If you want to declare further internal functions, there is no need to return a HOSTFN. You can declare the HOSTFNs on the header file as std::function though, that would be a cool optimization actually.
cpp/OpenSqliteHo.cpp
Outdated
| return location; | ||
| } | ||
|
|
||
| string OpenSqliteHo::getEncryptionKey(jsi::Runtime &rt, |
There was a problem hiding this comment.
If you really want to go this way, I would suggest to make this generic, being able to retrieve any key from the object. Put it in utils.h though.
|
Suggested changes applied on new commit |
|
Don't close this PR, we will use it to merge it to main |
No description provided.