Allow copying databases from custom assets path #94
Conversation
|
|
||
| // Create the output file in the documents directory | ||
| val databasesFolder = | ||
| context.getDatabasePath("defaultDatabase") | ||
| .absolutePath | ||
| .replace("defaultDatabase", "") | ||
|
|
||
| val outputFile = File(databasesFolder, "$name.$extension") | ||
| val outputFile = File(databasesFolder, filename) | ||
|
|
||
| if (outputFile.exists()) { |
There was a problem hiding this comment.
Would it not be more efficient to check if the output file exists before even opening the input stream, so that it is only opened if we will actually use it? This doesn't matter if we are overwriting the file, but in the case where we're not and the file already exists, it would make a difference.
There was a problem hiding this comment.
Don't think opening a stream makes such a difference, but I will move it.
| if(overwrite) { | ||
| outputFile.delete() | ||
| } else { | ||
| promise.resolve(true) |
There was a problem hiding this comment.
Shouldn't the input stream be closed here before resolving the promise and returning?
There was a problem hiding this comment.
Solved by moving the instantiation down
| extension: string | ||
| ): boolean => { | ||
| return NativeModules.OPSQLite.moveAssetsDatabase(dbName, extension); | ||
| export const moveAssetsDatabase = (args: { |
There was a problem hiding this comment.
This method's native implementation is now async so the definition here needs to be updated to reflect that.
There was a problem hiding this comment.
ah yeah, missed that. Thanks!
No description provided.