Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework question data structure #113

Merged
merged 20 commits into from
Nov 25, 2022
Merged

Rework question data structure #113

merged 20 commits into from
Nov 25, 2022

Conversation

Robbendebiene
Copy link
Member

@Robbendebiene Robbendebiene commented Oct 25, 2022 •
edited
Loading

This reworks the question catalog JSON structure as well as the internal models and some working principles.
The reason behind this is to simplify the JSON structure where possible while increasing its flexibility and power so future inputs like MultipleChoice can be implemented.

The previous uniform input structure is split in a

  • uniform part (the constructor) - so final OSM tag creation is still identical/centralized
  • heterogeneous part: (the input) - so input properties can be defined independently from other inputs

TODOs:

@Robbendebiene Robbendebiene mentioned this pull request Nov 21, 2022
Merged
@Robbendebiene
Merge pull request #115 from OPENER-next/fix_follow-up_questions_removal
d85464f 
Fix incomplete questionnaire entry removal when invalidating a pre-condition
@Robbendebiene
Fix wrong property name
7c6118e
@Robbendebiene Robbendebiene merged commit 7603233 into master Nov 25, 2022
@Robbendebiene Robbendebiene deleted the rework_question_data_structure branch December 9, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7h30n3 7h30n3 7h30n3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robbendebiene @7h30n3