Polish KeywordGenerator #4475
Merged
Polish KeywordGenerator #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
bska
force-pushed
the
polish-kw-generator
branch
from
f2ab222 to
e0b2490
Compare
akva2
approved these changes
Feb 11, 2025
| void write_file(const std::string& content, | ||
| const std::string& file, | ||
| const bool verbose, | ||
| const std::string& desc = "source") |
There was a problem hiding this comment.
i think we can drop the default?
True. I've pushed an update to that effect.
| return fmt::format("#ifndef PARSER_KEYWORDS_{0}_HPP\n" | ||
| "#define PARSER_KEYWORDS_{0}_HPP\n" | ||
| "#include <opm/input/eclipse/Parser/ParserKeyword.hpp>\n" | ||
| "namespace Opm {{\n" |
There was a problem hiding this comment.
may as well modernize, ie namespace Opm::ParserKeywords
There was a problem hiding this comment.
may as well modernize, i.e.,
namespace Opm::ParserKeywords
Agreed. I've pushed an update to that effect.
bska
force-pushed
the
polish-kw-generator
branch
2 times, most recently
from
6b0af23 to
140aa96
Compare
|
jenkins build this please |
akva2
reviewed
Feb 11, 2025
| void write_file(const std::stringstream& stream, | ||
| const std::string& file, | ||
| const bool verbose, | ||
| const std::string& desc = "source") |
There was a problem hiding this comment.
here as well?
😣
Thanks–I should have been more thorough before. I've pushed an update that I believe fixes that one as well...
Mostly by splitting long lines, removing needless declarations, and removing repeated 'std::endl' calls.
bska
force-pushed
the
polish-kw-generator
branch
from
140aa96 to
430924b
Compare
|
jenkins build this please |
|
PR approved and build check is green. I'll merge into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly by splitting long lines, removing needless declarations, and replacing repeated
std::endlcalls by\ncharacters where applicable.