Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected explicit energy solve forced to remain forward euler. #37

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

colemanjs
Copy link
Collaborator

@colemanjs colemanjs commented Oct 30, 2024

This PR have several changes focused on improving AdditiveFOAM for the JOSS review.

  1. The logic of the adaptive integration of the energy equation was updated to force the explicit solve using forward euler.
  2. ExaCA support was added for all heat transfer tutorials based on JOSS review comments.
  3. The foamToExaCA code was made into a FunctionObject to improve its IO handling.
  4. A new Allwmake script was added to the solver to collectively build the ExaCA FunctionObject, heatSourceModel library, and additivefoam solver.

Upon approval, the documentation needs to be updated at (https://ornl.github.io/AdditiveFOAM)

… added ExaCA support for all heat transfer tutorials
@colemanjs colemanjs requested a review from kincaidkc October 30, 2024 20:36
@colemanjs colemanjs self-assigned this Oct 30, 2024
@kincaidkc
Copy link
Collaborator

Do we want to include the foamToExaCADict for the tutorials but set execute to off by default?

@colemanjs
Copy link
Collaborator Author

Do we want to include the foamToExaCADict for the tutorials but set execute to off by default?

I think that OpenFOAM generally will enable execution if the configuration file and all arguments are provided in a case directory. Maybe we should just make foamToExaCADict a fuctionObject so that it inherits the expected OpenFOAM IO handling? Thoughts?

Copy link
Collaborator

@kincaidkc kincaidkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, glad we moved foamToExaCA to a function object and corrected the boundary condition naming convention.

@colemanjs colemanjs merged commit f484321 into main Nov 7, 2024
1 check passed
@colemanjs colemanjs deleted the forward-euler-for-explicit branch November 12, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants