Enable frozen points for boundaries #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abisner
reviewed
Dec 16, 2024
abisner
reviewed
Dec 17, 2024
|
@abisner tests added, mistakes fixed, and multiple sets of particles now possible |
streeve
force-pushed
the
frozen_points
branch
from
91d1a08 to
1a907b1
Compare
abisner
reviewed
Dec 24, 2024
There was a problem hiding this comment.
Tried to give it another pretty thorough pass. Just a few minor suggestions/fixes is all. One big takeaway in createParticles() is that the localOffset should always be updated to the final resized size, whereas the frozenOffset can sometimes be updated to "point" to the same localOffset.
streeve
force-pushed
the
frozen_points
branch
from
1a907b1 to
ffa234c
Compare
abisner
approved these changes
Dec 30, 2024
Clarify offsets vs number of frozen/local/ghost and add member functions
streeve
force-pushed
the
frozen_points
branch
from
ffa234c to
9cb643c
Compare
|
Reverted the change from offset->num for frozen. I agree that in most cases that's what we want to use. Will merge when pipelines pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds particle class methods for owned, ghost, and global sizes (separate commit)