Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move force details into models #172

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

streeve
Copy link
Collaborator

@streeve streeve commented Jan 9, 2025

First step in moving towards single force classes per pair/state/contact forms

  • Remove unused "set" functions and default constructors
  • Move repeated force class details into the base pmb/lps models

@streeve streeve requested a review from abisner January 9, 2025 17:41
@streeve streeve self-assigned this Jan 9, 2025
@streeve streeve force-pushed the update_force_models branch from 710f4fd to 22ce383 Compare January 9, 2025 18:11
This was referenced Jan 9, 2025
@streeve streeve merged commit 718e760 into ORNL:main Jan 22, 2025
14 checks passed
@streeve streeve deleted the update_force_models branch January 22, 2025 16:22
@streeve streeve mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants