Skip to content

Commit

Permalink
Address merge conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
JoshuaSBrown committed Apr 10, 2024
2 parents bb493be + 8ec199e commit 5003935
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 15 deletions.
4 changes: 2 additions & 2 deletions cmake/curl_version.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
#include <iostream>

/**
* This script is used to show what vesion of curl is being used with the
* rest of the build process and will print the version number of the curl
* This script is used to show what vesion of curl is being used with the
* rest of the build process and will print the version number of the curl
* library.
**/
int main() {
Expand Down
3 changes: 2 additions & 1 deletion common/include/common/CommunicatorFactory.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ class CommunicatorFactory {
LogContext m_log_context;

public:
explicit CommunicatorFactory(const LogContext & log_context) : m_log_context(log_context){};
explicit CommunicatorFactory(const LogContext & log_context)
: m_log_context(log_context){};

std::unique_ptr<ICommunicator> create(const SocketOptions &socket_options,
const ICredentials &credentials,
Expand Down
4 changes: 2 additions & 2 deletions common/include/common/DynaLog.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,14 @@ namespace SDMS {

/**
* Here unsigned int is used so that we can compare the numeric values when
* choosing whether to print a log message.
* choosing whether to print a log message.
*
* CRITICAL = 0
* ERROR = 1
* WARNING = 2
* INFO = 3
* DEBUG = 4
* TRACE = 5
* TRACE = 5
**/
enum class LogLevel : unsigned int {
CRITICAL,
Expand Down
3 changes: 2 additions & 1 deletion common/include/common/ServerFactory.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ class ServerFactory {
LogContext m_log_context;

public:
explicit ServerFactory(const LogContext & log_context) : m_log_context(log_context){};
explicit ServerFactory(const LogContext & log_context)
: m_log_context(log_context){};

std::unique_ptr<IServer> create(
ServerType server_type,
Expand Down
6 changes: 3 additions & 3 deletions common/source/servers/ProxyBasicZMQ.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

namespace SDMS {

std::string sanitize(std::string val, const std::string & pattern,
const std::string & replacement) {
std::string sanitize(std::string val, const std::string &pattern,
const std::string &replacement) {
for (auto at = val.find(pattern, 0); at != std::string::npos;
at = val.find(pattern, at + replacement.length())) {

Expand Down Expand Up @@ -186,7 +186,7 @@ void ProxyBasicZMQ::run() {
* loop.
**/
auto terminate_call = [](std::chrono::duration<double> duration,
const std::string & address, int thread_id,
const std::string &address, int thread_id,
LogContext log_context) {
log_context.thread_name += "-terminate_after_timeout";
log_context.thread_id = thread_id;
Expand Down
6 changes: 3 additions & 3 deletions core/server/AuthenticationManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ std::string AuthenticationManager::getUID(const std::string &public_key) const {
EXCEPT(1, "Unrecognized public_key during execution of getUID.");
}

void AuthenticationManager::addKey(const PublicKeyType & pub_key_type,
const std::string & public_key,
const std::string & uid) {
void AuthenticationManager::addKey(const PublicKeyType &pub_key_type,
const std::string &public_key,
const std::string &uid) {
std::lock_guard<std::mutex> lock(m_lock);
m_auth_mapper.addKey(pub_key_type, public_key, uid);
}
Expand Down
4 changes: 2 additions & 2 deletions core/server/AuthenticationManager.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ class AuthenticationManager : public IAuthenticationManager {
**/
virtual bool hasKey(const std::string &pub_key) const final;

void addKey(const PublicKeyType & pub_key_type, const std::string & public_key,
const std::string & uid);
void addKey(const PublicKeyType &pub_key_type, const std::string &public_key,
const std::string &uid);

/**
* Will the id or throw an error
Expand Down
2 changes: 1 addition & 1 deletion repository/server/RepoServer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ void Server::checkServerVersion() {
* The reasoning was that doing so would make the repo service dependent
* on the core actually running. By continually looping the coupling between
* the core services and the repo service is reduced.
**/
**/
while (true) {
++attempt;
DL_INFO(m_log_context,
Expand Down

0 comments on commit 5003935

Please sign in to comment.