Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAPS, Foxx] - 1180 refactor Part 2 authz #1224

Merged
merged 74 commits into from
Jan 17, 2025
Merged

[DAPS, Foxx] - 1180 refactor Part 2 authz #1224

merged 74 commits into from
Jan 17, 2025

Conversation

JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Jan 9, 2025 •
edited
Loading

PR Description

This PR is the second stage of refactoring of the authz feature. It includes using a strategy pattern for managing the different gridftp actions.

Tasks

  • - A description of the PR has been provided, and a diagram included if it is a new feature.
  • - Formatter has been run
  • - CHANGELOG comment has been added
  • - Labels have been assigned to the pr
  • - A reviwer has been added
  • - A user has been assigned to work on the pr
  • - If new feature a unit test has been added

Summary by Sourcery

Tests:

  • Added tests for authorization checks covering scenarios for admin users, regular users with/without ownership, and project administrators.

JoshuaSBrown and others added 30 commits December 19, 2024 14:44
@JoshuaSBrown
Remove useless comments
d8e0d2d
@JoshuaSBrown
Add repo class
feb5865
@JoshuaSBrown
Apply formatting
1dddc59
@JoshuaSBrown
Merge branch '1180-refactor-authz' into add-support-for-authz-lookup
e0a62f7
@JoshuaSBrown
unit_repo test to CMakeLists.txt
dc29840
@JoshuaSBrown
Merge branch '1180-refactor-authz' into add-support-for-authz-lookup
138a36c
@JoshuaSBrown
Fix entry for testing foxx repo
df3dc1f
@JoshuaSBrown
Add repo tests
33a6254
@JoshuaSBrown
Added more unit tests for the authz module
10f1e34
@JoshuaSBrown
Merge branch '1180-refactor-authz' into add-support-for-authz-lookup
f7a161f
@JoshuaSBrown @sourcery-ai
Update core/database/foxx/api/authz.js
68828e4 
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@JoshuaSBrown
Removed additional spaces.
d272932
@JoshuaSBrown @sourcery-ai
Update core/database/foxx/tests/repo.test.js
ad684dc 
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@JoshuaSBrown @sourcery-ai
Update core/database/foxx/api/authz.js
c0b0085 
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@JoshuaSBrown
Fix authz strategy call
adfccc6
@JoshuaSBrown @sourcery-ai
Update core/database/foxx/api/authz.js
3f3903a 
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@JoshuaSBrown
Merge remote-tracking branch 'origin/add-support-for-authz-lookup' in…
3a04af9 
…to add-support-for-authz-lookup
@JoshuaSBrown
Standardize error throw calls
f81bc28
@JoshuaSBrown
Fix key check
4fbf514
@JoshuaSBrown
Fix premature ; in test expect call
ae5dcef
@JoshuaSBrown
Correct unit tests
07fc637
@JoshuaSBrown
Merge branch '1180-refactor-authz' into add-support-for-authz-lookup
8089e1a
@JoshuaSBrown
Merge branch '1180-refactor-authz' into add-support-for-authz-lookup
5e572bd
@JoshuaSBrown
Update authz.test.js
e919b44 
Remove comment that is not useful.
@JoshuaSBrown
Add better comments around database method
97eab94
@JoshuaSBrown
Apply formatting
73c7f8c
@JoshuaSBrown
Address merge conflicts
5c800ed
@JoshuaSBrown
Fix syntax change
1f99bb9
@JoshuaSBrown
Address formatting of jquery file
a263250
@JoshuaSBrown
add more descriptive posix path error message
72e7c69
AronPerez
AronPerez requested changes Jan 15, 2025
View reviewed changes
core/database/foxx/api/repo.js Show resolved Hide resolved
core/database/foxx/api/repo.js Outdated Show resolved Hide resolved
core/database/foxx/api/repo.js Outdated Show resolved Hide resolved
core/database/foxx/api/repo.js Outdated Show resolved Hide resolved
core/database/foxx/tests/authz.test.js Outdated Show resolved Hide resolved
core/database/foxx/tests/user_router.test.js Show resolved Hide resolved
core/database/foxx/api/record.js Show resolved Hide resolved
core/database/foxx/api/record.js Show resolved Hide resolved
core/database/foxx/api/authz.js Show resolved Hide resolved
core/database/foxx/api/repo.js Outdated Show resolved Hide resolved
t-ramz
t-ramz reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@t-ramz t-ramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few questions/comments! Looking at tests next.

core/database/foxx/api/authz.js Show resolved Hide resolved
core/database/foxx/api/authz.js Show resolved Hide resolved
core/database/foxx/api/authz.js Show resolved Hide resolved
t-ramz
t-ramz reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@t-ramz t-ramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments on authz tests

core/database/foxx/tests/authz.test.js Show resolved Hide resolved
core/database/foxx/tests/authz.test.js
_id: data_id,
creator: "u/george",
},
{ waitForSync: true },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this is the first test waiting?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this might be a problem but it ended up not mattering.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the calls to avoid any confusion.

core/database/foxx/tests/authz.test.js Show resolved Hide resolved
t-ramz
t-ramz approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@t-ramz t-ramz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just make sure CI continues passing when merging #1225

@JoshuaSBrown JoshuaSBrown merged commit e7972b8 into devel Jan 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@t-ramz t-ramz t-ramz approved these changes

@AronPerez AronPerez Awaiting requested review from AronPerez

Assignees

@JoshuaSBrown JoshuaSBrown

Labels
Component: Database Relates to database microservice / data model Component: GridFTP Auth Module Relates to GridFTP authorization library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaSBrown @AronPerez @t-ramz