-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1199 feature add support for scoped lookup #1225
Open
JoshuaSBrown
wants to merge
35
commits into
1180-refactor-authz
Choose a base branch
from
1199-feature-add-support-for-scoped-lookup
base: 1180-refactor-authz
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 23 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
ed4398b
Add tests for foxx project class
JoshuaSBrown 5b5ee4e
Create initial strategy methods for authz
JoshuaSBrown 16d0d15
Implement strategy method calls in authz_router
JoshuaSBrown 86239e4
Add methods to repo class, for checking allocations, admins, and proj…
JoshuaSBrown 2c616d2
Add repo unit tests.
JoshuaSBrown c58ebab
Add abstractions for project and user, as well as unit tests for proj…
JoshuaSBrown 64bc44f
Move controllers into controller folder
JoshuaSBrown 552cf93
Pass in repo object to strategy methods
JoshuaSBrown d131a14
Pull in latest changes
JoshuaSBrown 1396f7f
Apply formatting to javasript in foxx
JoshuaSBrown 0ae304a
Address conflicts from formatting
JoshuaSBrown 4f62a05
Address JSDoc differences
JoshuaSBrown ca85a70
Address merge conflicts
JoshuaSBrown 85d1b1f
Address merge conflicts
JoshuaSBrown 8437b65
Address merge conflict
JoshuaSBrown 001f32d
Adjust controllers update from 1180
JoshuaSBrown 64a2fc2
Address differentces in authz.js
JoshuaSBrown 233d2a5
Further corrections to branch
JoshuaSBrown 88c3d6c
Address merge conflict
JoshuaSBrown bc34ad3
Address leftover diff header
JoshuaSBrown 584b196
Return true if access allowed
JoshuaSBrown 43ccca1
Remove debug commands
JoshuaSBrown 49c91f5
Merge in latest changes
JoshuaSBrown 6c586fb
Address merge conflict
JoshuaSBrown 86b5349
Remove superflous comments
JoshuaSBrown 5a291c4
Apply formatting
JoshuaSBrown f51b41f
Address eslint complaints about JSDoc
JoshuaSBrown cdb0dca
Test that NOT_FOUND error is thrown
JoshuaSBrown fb99dc2
Address feedback
JoshuaSBrown e7972b8
Merge pull request #1224 from ORNL/1180-refactor-authz
JoshuaSBrown 8249a5b
Merge branch 'devel' into 1199-feature-add-support-for-scoped-lookup
JoshuaSBrown 933e39d
Add in missing permission to lookupRecord authz call
JoshuaSBrown a18ab2c
Turn off automatic approval for lookup and chdir in repo
JoshuaSBrown fe578ed
Add missing gcs build trigger
JoshuaSBrown fa1ee90
Remove commented out code for lookup and chdir
JoshuaSBrown File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be console.error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good correction!