-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct JSDoc bug/warning #1264
Conversation
Reviewer's Guide by SourceryThis pull request introduces a minor JSDoc change to correct the casing of the 'Object' type in the transfer dialog component. Class diagram for TransferDialog componentclassDiagram
class TransferDialog {
+show(mode: number|null, records: Array<Object>|null, callback: Function)
}
note for TransferDialog "Updated JSDoc: Changed Array<object> to Array<Object>"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JoshuaSBrown - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please complete the PR requirements: add a proper description explaining the reason for this JSDoc change, fix the title typo, and check off the relevant items in the checklist before this can be merged.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
See Issue, this is not an issue. |
Closing because non-issue |
PR Description
Tasks
Summary by Sourcery
Fix JSDoc type casing.
Enhancements:
TransferDialog
component.Documentation:
records
parameter in theshow
method of theTransferDialog
class.