-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var #1270
Add env var #1270
Conversation
Reviewer's Guide by SourceryThis pull request addresses an unbound variable issue by adding an environment variable. No diagrams generated as the changes look simple and do not need a visual representation. Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JoshuaSBrown - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide a more detailed description explaining which environment variable is being added and what unbound variable issue is being fixed.
- The PR checklist items need to be completed to indicate whether required steps have been taken.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to add ENABLE_FOXX_TESTS
to the docker-compose files
under datafed-foxx
PR Description
Address unbound var.
Tasks
Summary by Sourcery
Chores: